search

Clon1998 / mobileraker

A Flutter mobile app for Klipper/Moonraker
Other
490 stars 56 forks source link

Add more detailed ETAs and estimates #43

Closed Charghoul closed 11 months ago

Charghoul commented 2 years ago

It would be really great to get all the print time estimates and ETA times that the mainsailOS provides.

Not sure why, but the estimates ETA that mobileraker provides is always different from what mainsailOS shows.

Clon1998 commented 2 years ago

Not sure why, but the estimates ETA that mobileraker provides is always different from what mainsailOS shows.

The reason for that is that Mobielraker uses only one source while Mainsail combines the mentioned calculation sources and combines them to ensure the best eta.

Currently Mobileraker uses this formula to calculate the eta: https://github.com/Clon1998/mobileraker/blob/92c74903c7b77df6fa32d021a8cc808c635d3e80/lib/dto/machine/printer.dart#L35-L42

Regarding the estimated print time, Mobileraker only uses the values from Moonraker. https://github.com/Clon1998/mobileraker/blob/f16065e0567fa4630bd40f9d0e19a68074f7d990/lib/ui/views/files/details/file_details_viewmodel.dart#L86-L92

Clon1998 commented 11 months ago

Eta and estimates are available now via a tooltip by long pressing the ETA cell.

locki-cz commented 6 months ago

There is not possible set ETA to show slicer?

Clon1998 commented 6 months ago

Long pressing the eta cell will bring up the tooltip that shows all available ETAs

image

locki-cz commented 6 months ago

I understand it from previous replyes ... but i can see in mainsail info from slicer on klipper screen info from slicer but there is some weird eta ... is possible add it to setting and see same info also in this great app? image App now it shows by default AVG ... which is every time very off

Clon1998 commented 6 months ago

I understand it from previous replyes ... but i can see in mainsail info from slicer on klipper screen info from slicer but there is some weird eta ... is possible add it to setting and see same info also in this great app? image App now it shows by default AVG ... which is every time very off

I am not quit sure what you are asking for? The app is able to show all estimates if necessary. The ETA that is shown is calculated based of the AVG of all available estimate sources:

https://github.com/Clon1998/mobileraker/blob/9e4e11b67e765d51dde161f10a05f6afb8b2f0bc/common/lib/data/dto/machine/printer.dart#L210-L234

https://github.com/Clon1998/mobileraker/blob/9e4e11b67e765d51dde161f10a05f6afb8b2f0bc/common/lib/data/dto/machine/printer.dart#L181-L185

Are you talking about the ability to select what kind of ETA is shown on the dashboard? So you can choose if you want to use AVG, slicer, file... as source for that?

locki-cz commented 6 months ago

I just want to see the exact same ETA as displayed in Mainsail or on the klipperscreen. A random average number is useless to me. I don't need to see them all. I just want to see the one that is correct.

I apologize if that wasn't clear from my previous responses.

Clon1998 commented 6 months ago

I just want to see the exact same ETA as displayed in Mainsail or on the klipperscreen. A random average number is useless to me. I don't need to see them all. I just want to see the one that is correct.

I apologize if that wasn't clear from my previous responses.

Okay got it. It is not a random number. In fact I am using the exact same logic as Mainsail does:

https://github.com/mainsail-crew/mainsail/blob/fa61d4ef9297426a404dd845a1a4d5e4525c43dc/src/store/printer/getters.ts#L647-L729

I am currently printing a 12hrs print, and both my mainsail and app show the exact same ETA values. However, in contrast to Mobileraker, Mainsail lets you pick the ETA calculation sources on which it runs an AVG calculation. Can you verify that you enabled all values on mainsail for that calculation in the Settings -> General -> Eta Calc