search

CloneWith / osu

Another osu! client fork, tailored for tournament hosting
https://osu.ppy.sh
MIT License
1 stars 0 forks source link

User current rank / PP does not display correctly #15

Closed NaughtyChas closed 3 months ago

NaughtyChas commented 3 months ago

Found in the development process of issue #14 .

NaughtyChas commented 3 months ago

The displayed global rank does not match current value:

on website in tourney (board scene) rank 2 days ago
image image image

The value only matches the rank 2-5 days ago.

Layout and code defined at osu.Game.Tournament/Components/TeamPlayerCard.cs, at line 81-107, on branch derived/tboard_ntcsAppend:

We use teamPlayer?.Statistics.GlobalRank to gather rank, which the value is incorrect.

Same for PP, at at line 81-107, we use teamPlayer?.Statistics.PP which return nothing.

To see its original effect on rank + PP display, head into Team Editor section, defined at line 52-62 in file osu.Game/Users/UserListPanel.cs:

string performance = User.Statistics?.PP?.ToString("N0") ?? "-"; is used to assign PP value gathered into performance. As no value is being gathered, - is always being displayed on the panel:

image

Help wanted, as we are wondering if we have used the wrong API, or other parts of the code went wrong. Pinging for @cdwcgt for help.

NaughtyChas commented 3 months ago

Resolved by @cdwcgt in commit 6d9fe12 on branch derived/tboard_cdwcgtAppend:

image

Huge thanks from the team!