Closed CloneWith closed 3 months ago
- [x] Validation
Further information required for "Validation". Pinging @CloneWith
- [x] Add rounded corner visual style for IRC chat board. (Appended)
Maybe worth considering to add this visual style for better looking.
Further information required for "Validation".
Since I didnt have a channel to display in the Chat section, it might be good to let you have a look at the changes. If everything seems okay then we could safely check this off the list.
Further information required for "Validation".
Since I didnt have a channel to display in the Chat section, it might be good to let you have a look at the changes. If everything seems okay then we could safely check this off the list.
Chatbox is working as expected, checked this off:
Maybe worth considering to add this visual style for better looking.
Just added a round corner of 10(px?) in the latest commit, and accidentally pushed to your branch ;w; Anyway you can try it at your side...
Maybe worth considering to add this visual style for better looking.
Just added a round corner of 10(px?) in the latest commit, and accidentally pushed to your branch ;w; Anyway you can try it at your side...
Reviewed.
- [x] Move the round title somewhere else
See commit 72f4385.
We have to use the same chatbox layout in EX Scene, more about this will be traced in a new issue #4 .
latest version of osu!(lazer) in release 2024.731.0 has changed the visual for chat boxes:
Careful when syncing main branch if we don't want this new visual style.
[Edited]
Confirm on using the legacy chatbox design. DO NOT sync main branch or we have to find a fix to address this.
Careful when syncing main branch if we don't want this new visual style.
thx for noticing me about this!
Our group definitely won't want this I think.
I'll try to find out if there is a reachable variable controlling this behaviour.
I'll try to find out if there is a reachable variable controlling this behaviour.
Fortunately the contributor kindly used a public struct, enabling us to simply change this argument on message line definition:
protected partial class MatchMessage : StandAloneMessage
{
public MatchMessage(Message message, LadderInfo info)
: base(message)
{
// Disable alternating background
AlternatingBackground = false;
if (info.CurrentMatch.Value is TournamentMatch match)
{
if (match.Team1.Value?.Players.Any(u => u.OnlineID == Message.Sender.OnlineID) == true)
UsernameColour = TournamentGame.COLOUR_RED;
else if (match.Team2.Value?.Players.Any(u => u.OnlineID == Message.Sender.OnlineID) == true)
UsernameColour = TournamentGame.COLOUR_BLUE;
}
}
}
I'll update our branch and try this patch.
In commit 47feaad I have disabled that AlternatingBackground
effect for chatboxes. Apart from that, some details are worth notice:
Before release 2024.731.0 | After release 2024.731.0 |
---|---|
Chat timestamps are displayed differently. Waiting feedback from other groupmembers...
Have implemented a simple layout with the Chat display at the left side of the Board.
Further work needs to be done to: