search

ClonedOne / MalwareBackdoors

Code for the paper Explanation-Guided Backdoor Poisoning Attacks Against Malware Classifiers
MIT License
56 stars 7 forks source link

code has a bug in model_utils.py #5

Open wxt406611016 opened 2 years ago

wxt406611016 commented 2 years ago

Hi, i was running your code for attacking lightgbm on ember recently, but found a bug in model_utils.py/def get_explanations_lightgbm(). For future use so i set 'save' parameter to be True ,and after that i saved explanations file. But the performance drops a lot when i used saved explanations file. It bothers me a lot , so i checked whats wrong with it. Luckily i found something wrong when reading the csv file. The bug exists when 'load' parameter is set True, what returns is not a proper format, "pd.read_csv(fpath)" has a shape of (2352,n) ,actually it should be (2351,n) , which means one more column is added. After checking i found the index column is added. So the proper return of the function should be pd.read_csv(fpath,index_col=0). Hopes it will be helpful to you.

ClonedOne commented 2 years ago

Thank you for the report, I'll double check if that function is used somewhere

wxt406611016 commented 2 years ago

Thank you for the report, I'll double check if that function is used somewhere

also exisits in pdfrf dataset when get explanations files