Clonetrooperkev / openintents

Automatically exported from code.google.com/p/openintents
0 stars 0 forks source link

OI Countdown: Black font on black background #489

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a new countdown in OI Countdown.
2. Activate the check box for "Action:" 

What is the expected output? What do you see instead?
A dialog "Set action" appears, with "Shortcuts" and "Automation tasks".
In Android 4.0 these two options appear as black on dark gray.

The color of this text should be set in a proper way through system styles, to 
ensure backward as well as forward compatibility.

The patch must be tested on all major Android versions, 1.x, 2.x, 3.x, 4.x, 
since the colors of background and foreground may differ.

Original issue reported on code.google.com by peli0...@googlemail.com on 10 Jan 2012 at 12:26

GoogleCodeExporter commented 9 years ago
Just one question, what do you mean by "system styles"?

Original comment by dkremov on 14 Jan 2012 at 7:55

GoogleCodeExporter commented 9 years ago
I had in mind something like this:
http://android-developers.blogspot.com/2012/01/holo-everywhere.html

See section "Using Holo while supporting Android 2.x", also that we also want 
to support 1.x.

Original comment by peli0...@googlemail.com on 14 Jan 2012 at 12:18

GoogleCodeExporter commented 9 years ago
http://www.google-melange.com/gci/task/view/google/gci2011/7120271

Original comment by peli0...@googlemail.com on 14 Jan 2012 at 12:36

GoogleCodeExporter commented 9 years ago
Do you think the option suggested here is good 
http://developer.android.com/guide/topics/ui/themes.html#SelectATheme

Original comment by dkremov on 14 Jan 2012 at 1:28

GoogleCodeExporter commented 9 years ago
Yes, it is the same solution that I had linked to above in comment 2, too, I 
think :-)

Original comment by peli0...@googlemail.com on 14 Jan 2012 at 1:32

GoogleCodeExporter commented 9 years ago
Only point is, try to avoid to duplicate large parts of an xml file, because 
this will be difficult to maintain in the future. (e.g. don't simply put a long 
layout.xml in various version folders, with small modifications each).

Only put very small sections of an xml file into a version-specific xml file, 
and link to those from one single master layout.xml file.

Original comment by peli0...@googlemail.com on 14 Jan 2012 at 1:34

GoogleCodeExporter commented 9 years ago
OK, so basically I want to try to keep the old layout for versions lower than 
Android 3.0, while for the new ones to use something like Holo Light, but will 
test later (after I do the xml things) and will try to upload screenshots.

Original comment by dkremov on 15 Jan 2012 at 8:34

GoogleCodeExporter commented 9 years ago
By the way, I'm supposed only to work on the black font on the grey background 
when the "Set Action" dialog comes up, right? I must set the style  of this 
dialog to Holo on Android 3+ or just Android 4+?

Original comment by dkremov on 16 Jan 2012 at 12:25

GoogleCodeExporter commented 9 years ago
Yes, this issue is actually just about the font in the dialog. Maybe even 
setting the holo style is overkill, and one simply needs to change the font 
color?
(but of course you are free to provide any other more general solution)

But yes, one should test if Android 3+ is affected as well, which I can only 
tell you later tonight...

Original comment by peli0...@googlemail.com on 16 Jan 2012 at 2:04

GoogleCodeExporter commented 9 years ago
Ok, I must only find the files for the dialog - the .java and the .xml, if any. 
Then I will start tinkering and will see what happens. At first I will try with 
just changing the font color, after that I will see about the Holo styles, are 
they needed or not...

Original comment by dkremov on 16 Jan 2012 at 2:39

GoogleCodeExporter commented 9 years ago
Ah, well, I give up - I can't find the file that controls the dialog. I found 
the pngs for the images in it, I found the xmls for everything else, but I 
can't find the file for the text and it's font and style

Original comment by dkremov on 18 Jan 2012 at 2:08

GoogleCodeExporter commented 9 years ago
So if you can please tell me which file it is, then I can start the "real" 
work..

Original comment by dkremov on 18 Jan 2012 at 2:09

GoogleCodeExporter commented 9 years ago
Do you mean this?
http://code.google.com/p/openintents/source/browse/trunk/countdown/Countdown/src
/org/openintents/countdown/activity/SelectTaskDialog.java#36

There is a suspicious line here:
http://code.google.com/p/openintents/source/browse/trunk/countdown/Countdown/src
/org/openintents/countdown/activity/SelectTaskDialog.java#64
builder.setInverseBackgroundForced(true);

I wonder what it does in connection with the holo theme.

The adapter is here:
http://code.google.com/p/openintents/source/browse/trunk/countdown/Countdown/src
/org/openintents/countdown/activity/AddAdapter.java#66

Original comment by peli0...@googlemail.com on 18 Jan 2012 at 3:35

GoogleCodeExporter commented 9 years ago
Google Code-in ended.

Original comment by peli0...@googlemail.com on 22 Jan 2012 at 12:53

GoogleCodeExporter commented 9 years ago
Hi! Sorry for my lack of progress, I was busy. Will try to work today.

Original comment by dkremov on 22 Jan 2012 at 8:53

GoogleCodeExporter commented 9 years ago
A related issue in OI Shopping List was fixed here, simply by manually changing 
the text color, if the version was honeycomb and above.
http://code.google.com/p/openintents/issues/detail?id=452
http://code.google.com/p/openintents/source/detail?r=4086#

I confirm that this issue exists on Android 3.0 as well, so Build >= HONEYCOMB 
should work as a check whether to set the white color.

Original comment by peli0...@googlemail.com on 22 Jan 2012 at 9:18

GoogleCodeExporter commented 9 years ago
I "unclaim" as I will be busy these days and so I won't be  able to try to fix 
the issue, sorry though.

Original comment by dkremov on 22 Jan 2012 at 2:24