Clooos / Bubble-Card

Bubble Card is a minimalist card collection for Home Assistant with a nice pop-up touch.
MIT License
1.62k stars 46 forks source link

Custom button does not call tap_action #333

Closed Kamii closed 7 months ago

Kamii commented 7 months ago

Describe the bug When clicking on a custom button the tap action is not called. It works when clicking on the icon (icon-container).

To Reproduce Steps to reproduce the behavior:

  1. Add a custom button with tap_action. e.g:
      - type: custom:bubble-card
        card_type: button
        button_type: custom
        entity: light.lights_kitchen
        name: Köket
        icon: mdi:fridge
        tap_action:
          action: navigate
          navigation_path: '#kitchen'
  2. Click on the label in the button

Expected behavior Call the tap action

Screenshots Nothing happens

Desktop (please complete the following information):

Additional context I did a update today and it stopped working on both my phone and desktop

Clooos commented 7 months ago

Thanks for pointing me this issue, the new v1.6.0 breaked it indeed. This will be fixed in the next release.

andreasbrett commented 7 months ago

Thanks for pointing me this issue, the new v1.6.0 breaked it indeed. This will be fixed in the next release.

Do you have a plan which release that will be? I'm on 1.6.3 and the buttons are still only working when clicking the icon.

Clooos commented 7 months ago

Sorry, I've rushed the other fixes for the v1.6.3, but it will be fixed in the v1.6.4.

Clooos commented 7 months ago

This is now fixed! Sorry for the delay! https://github.com/Clooos/Bubble-Card/releases/tag/v1.6.4

andreasbrett commented 7 months ago

This is now fixed! Sorry for the delay! https://github.com/Clooos/Bubble-Card/releases/tag/v1.6.4

works for me

Clooos commented 7 months ago

Yeah! 🍻