Clooos / Bubble-Card

Bubble Card is a minimalist card collection for Home Assistant with a nice pop-up touch.
MIT License
1.46k stars 41 forks source link

Add a state card #381

Closed brunosabot closed 3 months ago

brunosabot commented 5 months ago

Hello there!

I found your custom cards awesome and it changes the way I display my dashboard. There is however one thing missing for me: a basic state card. This can be used to display basic informations such as a room temperature, days before/since a date, a battery percentage, ... It could have been a custom button, but on this one the whole card would be colored, have default toggle action that does not really make sense and does not display the actual state value by default.

What do you think?

Clooos commented 5 months ago

Hi and thanks!

This is already on my todo list but I have a bigger project in mind for the (not too distant 🀞) future of Bubble Card. I’m planning to add a new card type that can be fully customized in the GUI editor to fit everyone’s needs, like a media player with buttons, a thermostat card or even a simple state card.

But for now I still have to focus on performance and stability, while the next release will introduce some nice new features and will be much faster πŸ₯³

Edit: I did not realized that it was a pull request! I tought that it was a feature request! I will take a look a that probably monday. Thanks!

brunosabot commented 5 months ago

I can also dig into the performances into another PR if you don't have time right now 😁

Clooos commented 5 months ago

The performance issue is totally fixed on my side and this is so much faster now! I can't wait to release this new version but I still have some issues to fix first.

And finally I've tried your PR yesterday, it's a nice addition. But it could be better to add it as a new button_type don't you think? And it could be great if you could add the editor part too if it's not too much to ask 😁

Thanks a lot again for helping me!

brunosabot commented 4 months ago

But it could be better to add it as a new button_type don't you think?

I can change that, you tell me πŸ˜…

So you can understand why I chose that, my reasons were:

The performance issue is totally fixed on my side

I worked for fun on this part, and I think there is an opportunity to do more. I'll share you an insight of this later. Edit: I made a pull request on my fork to explain what I did. Do not hesitate to ask questions on it!

add the editor part too if it's not too much to ask

Sure! I'll look how this works. Edit: Done!

Clooos commented 4 months ago

I've merged your other PR first and now there is a conflict. And I'm not sure of what to do, your help will be very appreciated πŸ˜…

brunosabot commented 4 months ago

No problem, I knew this would happen! 😁

I can do the fix, but what should I do with this pull request?

I'll sticked to your vision and your choices for this project and then helping the most I can :D

Edit: the conflict is solved

Clooos commented 4 months ago

Thanks! And I really like your third option, but I guess that it could be better to add it as a new button_type, because it's still some kind of button and it shares a lot of similarities from them.

And one more time thank you! I'm really glad to finally have someone that can help me improving this huge project in the right direction!

brunosabot commented 4 months ago

I'm almost done with the PR adding state as a button and with the perf improvement we talked about. Is there a way I can find all the possible use cases to test them so I'm sure nothing is regressing? (I contacted you on Reddit about this, not sure where would be the right place to do so)

Clooos commented 4 months ago

Hi, I've answered on Reddit.

Clooos commented 3 months ago

Best PR in the world, thank you a lot again for this amazing and impressive work 🍻