Clooos / Bubble-Card

Bubble Card is a minimalist card collection for Home Assistant with a nice pop-up touch.
MIT License
1.44k stars 39 forks source link

[v2.0.0-rc.1] Minor issue with battery icon state #548

Closed willliamchan closed 3 weeks ago

willliamchan commented 3 weeks ago

For any feature request you can open a new discussion here:
https://github.com/Clooos/Bubble-Card/discussions/categories/feature-requests
For any question you can open a new discussion here:
https://github.com/Clooos/Bubble-Card/discussions/categories/q-a

Describe the bug
When battery level is 100% and bubble card uses 90% full icon.

Expected behavior
When battery is 100% to use mdi:battery instead of mdi:battery-90

Thank you! 🍻

Clooos commented 3 weeks ago

Hi, I was aware of that and this issue should be fixed it the new... v2 stable release! πŸŽ‰

https://github.com/Clooos/Bubble-Card/releases/tag/v2.0.0

willliamchan commented 3 weeks ago

Hi, I was aware of that and this issue should be fixed it the new... v2 stable release! πŸŽ‰

https://github.com/Clooos/Bubble-Card/releases/tag/v2.0.0

Thanks just tried 2.0.0 and didn’t work out as expected, please see below:-

RC1 IMG_0957

2.0.0 IMG_0955

Clooos commented 3 weeks ago

I haven't changed anything related to this. This is really weird πŸ˜…

willliamchan commented 3 weeks ago

I haven't changed anything related to this. This is really weird πŸ˜…

Let me give it another try, maybe something to do with cache again.

Clooos commented 3 weeks ago
image

Well... sorry!

willliamchan commented 3 weeks ago
image

Well... sorry!

Don’t mention it! Still bubble card lover! And my dashboard is back in business!

Clooos commented 3 weeks ago

And by the way is the battery icon issue correctly fixed?

Edit: I love your dashboard by the way!

willliamchan commented 3 weeks ago

And by the way is the battery icon issue correctly fixed?

Edit: I love your dashboard by the way!

Oh yea its fixed! This is all thanks to your "if else" example earlier and now I have my own set of "muted" color tone created for different kind of entity, in fact it's now custom styles everywhere and i am hoping to learn about building theme so I can have them set as default.

Anyway I should have this issue closed first!