Clooos / Bubble-Card

Bubble Card is a minimalist card collection for Home Assistant with a nice pop-up touch.
MIT License
1.96k stars 57 forks source link

Light Entity Icon Color #692

Open joshuazd opened 3 months ago

joshuazd commented 3 months ago

Describe the bug
The icon color of light entities is hard coded in the card when the light is on, instead of using variables. Additionally, the icon background is handled in a way that makes the icon hard to see when using a light theme and --ha-card-background is close to white.

To Reproduce
Steps to reproduce the behavior:

  1. Use a theme with a light mode (the default Home Assistant theme works)
  2. Create a bubble card for a light
  3. Turn the light on

Expected behavior
The icon should respect the --state-light-active-color variable. I think the fallback order the tile card uses is --state-light-on-color -> --state-light-active-color -> --state-active-color. Handle the color of the icon background so that the icon is more visible

Screenshots
Current state: Screenshot 2024-08-08 at 13 05 52

Tile card example: Screenshot 2024-08-08 at 13 04 15

Informations (please complete the following information):

Thank you! 🍻

ncodee commented 2 months ago

+1. Also, the Card background doesn’t always reflect the actual Light colour, so this can be confusing and unreadable at times.

samuel9554 commented 2 months ago

+1 I confirm the issue image

Ya7ya-mohammed commented 2 months ago

Did you solve it please

a-bianucci commented 1 month ago

Same here - noticing that in styling sub buttons can't get the state active color

Clooos commented 1 month ago

Hi! I've added this issue to my to-do list. I'm working on a really complex issue (the editor slowness on some configs) but I hope it will be fixed soon so that I can move on to other ones 🤞

oerix commented 3 weeks ago

+1, hoping this will be fixed soon, thanks.