search

Clooos / Bubble-Card

Bubble Card is a minimalist card collection for Home Assistant with a nice pop-up touch.
MIT License
2.02k stars 57 forks source link

Dragging over a bubble card triggers a popup #839

Open michaelarnauts opened 1 month ago

michaelarnauts commented 1 month ago

Describe the bug
When dragging over a button card (to scroll down), a popup is triggered.

Also, when using swipe navigation, the same happens when scrolling left/right to navigate to a different tab.

To Reproduce
Steps to reproduce the behavior:

  1. Add a few bubble cards to a dashboard
  2. Drag down to scroll (on mobile)
  3. A popup is triggered of the bubble card where dragging was initiated.

Expected behavior
Just scroll down without triggering a popup.

Screenshots
If applicable, add screenshots to help explain your problem.

YAML
If applicable, add any relevant YAML code.

Your code here

Informations (please complete the following information):

Additional context
Add any other context about the problem here.

Thank you! 🍻

FalkPe commented 1 month ago

I have the same problem

Clooos commented 1 month ago

Hi! I'm already on it! It will be perfect in the next beta 👌

Tee86 commented 1 month ago

@Clooos , not sure if this info helps you, but I don't have this issue at all and the config is the same: OS: Android Browser/App: Official HA app Bubble Card version: 2.3.0 beta 2 Home Assistant version: 2024.10.1

Nor my client who uses iOs app reported this behaviour. Looks like a specific conflict issue with other integration that I don't have installed on my server.

Clooos commented 1 month ago

This issue is already fixed, I just need a bit more time for releasing the new beta.

michaelarnauts commented 1 month ago

@Clooos could you already commit the fix to the main branch? I could use the latest main in HACS then while waiting for a release.

Clooos commented 1 month ago

Done 👌

michaelarnauts commented 1 month ago

Unfortunately, it still has an issue, when scrolling down, but the viewport is already at the bottom (or scrolling up at the top), the click is still triggered.

A click is also triggered when scrolling to the side (when using swipe navigation to switch to the next tab).

peterthepeter commented 1 month ago

Hello,

Unfortunately I still have the problem with Bubble Card v2.3.0-beta.3

on my iPhone with Safari or Arc. iOS 18.0.1

Best regards Christian

sebster6 commented 2 weeks ago

Same issue on beta 4 as well :(

iOS 18.1 Home Assistant Companion App 2024.9.4 Home Assistant 2024.10.3

Clooos commented 2 weeks ago

Hi! This issue should be definitely fixed in the next release, I've added a new system that disable all actions when a scroll is detected. This time it should perfect 🤞

michaelarnauts commented 2 weeks ago

Hi! This issue should be definitely fixed in the next release, I've added a new system that disable all actions when a scroll is detected. This time it should perfect 🤞

There still is the case where you drag down while at the bottom of the page. This doesn't trigger a scroll, but shouldn't trigger a click.

The same for horizontal dragging (when used with swipe navigation), this also doesn't scroll.

michaelarnauts commented 1 week ago

@Clooos beta5 fixed it for the vertical scrolling, but it still triggers a popup (or a click when the action is toggle) when doing a horizontal swipe (to move to the next page).

Clooos commented 1 week ago

Damn, I haven't covered the horizontal swipe indeed! 🫠

Clooos commented 1 week ago

@michaelarnauts I've just tried and I'm unable to reproduce it (at least on the Android HA app), can you tell me how to reproduce this?

michaelarnauts commented 1 week ago

I have swipe navigation installed (https://github.com/zanna-37/hass-swipe-navigation) and configured.

Then, when you have multiple tabs in your dashboard, you can swipe left and right to move to another tab.

When doing this over a bubble cart button, the more info dialog pops up. It actually seems to trigger the click action causing the more info dialog to show.

Clooos commented 1 week ago

Do you had this issue before the v2.3.0 betas? Even if it was not the case before, I have developed a new system for the actions that is much more efficient and I'm not sure that I can do much since this issue seems to only happen in combination with swipe navigation.

But I'm probably wrong, it is just difficult for me to cover every cases just by myself, so if anyone want to contribute on this, he will be more than welcome!