search

Cloud-Architects / cloudiscovery

The tool to help you discover resources in the cloud environment
Apache License 2.0
779 stars 92 forks source link

Add IBM Provider #181

Open MalarvizhiK opened 3 years ago

MalarvizhiK commented 3 years ago

Added code for IBM Provider. I have added Network with few resources: route_table, subnet, vpc, security group, access control list.

Here is the command to run IBM Provider:

Malars-MacBook-Pro-2:cloudiscovery malark$ python cloudiscovery/init.py ibm-vpc --region_name "us-south" --vpc_id "r006-............" --api_key "my api key for ibm"

MalarvizhiK commented 3 years ago

Please find attached the diagram for the same. I have sent in email to leandro.damascena@gmail.com

MalarvizhiK commented 3 years ago

@leandrodamascena @meshuga For some reason, my code fails with "Use of exec detected", even though, I disabled with "pylint" error. Please look into this.

leandrodamascena commented 3 years ago

Hi @MalarvizhiK! Thanks for PR! Tomorrow I'll work on this! 👏

MalarvizhiK commented 3 years ago

@leandrodamascena @meshuga You may need to take the latest diagrams which has diagrams for IBM Cloud Provider.

Command to run for IBM Provider :

python cloudiscovery/init.py ibm-vpc --region_name "us-south" --api_key "My API KEY" --vpc_id "r006-127881e9-......" --diagram yes

pip3 install --upgrade "ibm-vpc>=0.6.0"

pip3 install 'diagrams==0.20.0'

MalarvizhiK commented 3 years ago

@leandrodamascena @meshuga Any news on this PR ?

MalarvizhiK commented 2 years ago
Arrow_Diagram

single_vpc All_Resources We have implemented diagrams for IBM Cloud Provider. The code is available in IBM github repo: github.ibm.com

meshuga commented 2 years ago

Hi @MalarvizhiK. Thank you for your contribution. I don't currently have capacity to maintain the project (with constant hope for this to change) but I want to ask you to do two things:

  1. Cloudiscovery is an OSS project with Apache 2.0 license, which means that all changes to the project should remain public. Your changes are in private IBM repository, which isn't pro OSS openness and community building, which is the whole point of open source. Can you at least make the fork public? Would be great to keep fork on GH, so can keep the PR and eventually merge it.
  2. The PR with last commits have build errors, once you publish your recent changes, please have a look to fix build
MalarvizhiK commented 2 years ago

@meshuga We are currently working on integrating our code with this repo. We will raise a PR as soon as its ready.