search

Cloud-Automation / node-modbus

Modbus TCP Client/Server implementation for Node.JS
471 stars 175 forks source link

Feature request: make rtu / serial support optional #117

Closed flottokarotto closed 7 years ago

flottokarotto commented 7 years ago

serialport is the only native dependency. jsmodbus would be a js-only modbus solution without it.

stefanpoeter commented 7 years ago

There is an option for npm packages to declare certain dependencies as optional. This way the module will be installed even thou this optional module is missing or it's installation routine failed. So this could be done. Why do you want it to be js-only?

flottokarotto commented 7 years ago

For cross-build environments (e.g. open embedded), it is necessary to delete all native dependencies inside node_modules (or complete node_modules). A js-only solution would be a lot easier to deploy.

stefanpoeter commented 7 years ago

You can always fork this project without the native dependencies. Since serial is already introduced here I won't take it back, sorry.

GermanBluefox commented 7 years ago

I must say, that would to prefer to move serialport to optional dependencies. It is really optional an as far as I know almost no one use this node as serial rtu. I want to prepare pull request to fix chanking with serial.

If you move serialport to optional you loose nothing. The people who wants to use this packet with serial port, they will care about properly installation. And the people who wants to use just over tcp they are just happy. My platform runs on very different devices, nas, arm5, and so on. The world is not only raspi, Mac and PC.

Am 16.02.2017 15:52 schrieb "Stefan Poeter" notifications@github.com:

You can always fork this project without the native dependencies. Since serial is already introduced here I won't take it back, sorry.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Cloud-Automation/node-modbus/issues/117#issuecomment-280351442, or mute the thread https://github.com/notifications/unsubscribe-auth/AEXqgLq0mlsF5nmX3Lqf7rdLlwqIOOSHks5rdGKygaJpZM4L08Gt .

stefanpoeter commented 7 years ago

See branch v3.0.0-alpha: The serialport is no longer a dependency. Yet you are able to create a rtu (serial) client.