search

Cloud-Automation / node-modbus

Modbus TCP Client/Server implementation for Node.JS
471 stars 175 forks source link

White list IPs, that server accepts #127

Closed joroaf closed 7 years ago

stefanpoeter commented 7 years ago

Hey @joroaf, thanks for your input. A quick note on that.

First, make sure to check npm test before commiting since TravisCI has complaints about your commit. It is probably because of a missing syntax (We apply the standard javascript syntax).

Second, your whitelist would break with lower versions since no modbus server would accept any connection as long as there is no whitelist defined. Make sure everything works when there is no whitelist defined.

Third, test and document. Write a test to prove your code works and make some additions to the README.md.

Keep up the good work.

stefanpoeter commented 7 years ago

That was quick. We still need some tests to verify that your additions work.

joroaf commented 7 years ago

Hey @stefanpoeter, I think it's ready to merge