search

Cloud-Automation / node-modbus

Modbus TCP Client/Server implementation for Node.JS
466 stars 174 forks source link

Read Coils example for TCP Server #157

Closed AnthonyMujic closed 6 years ago

AnthonyMujic commented 6 years ago

Made a series of changes to get the SimpleServer and ReadCoils examples working. This is my first ever pull request, so I welcome any feedback. Not sure if this pull request is too big, and should be split into a number of pull requests, or if it is too basic, and more features should be added before making a pull request?

stefanpoeter commented 6 years ago

Hey @AnthonyMujic, great work. I think the way you did it is just fine since these are some basic changes that are related to the ReadCoils Example. I like that you provided a test method.

I'll made a comment on the assert in the test, besides that I could merge it.

AnthonyMujic commented 6 years ago

Thanks for the feedback. I have corrected the assertion as suggested.

stefanpoeter commented 6 years ago

Thanks for your work, keep it up. If you want to continue working on v3 then I suggest I'll make you a project member. What do you say?

AnthonyMujic commented 6 years ago

That sounds great.

On Fri, Dec 29, 2017 at 7:12 PM, Stefan Poeter notifications@github.com wrote:

Thanks for your work, keep it up. If you want to continue working on v3 then I suggest I'll make you a project member. What do you say?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Cloud-Automation/node-modbus/pull/157#issuecomment-354413559, or mute the thread https://github.com/notifications/unsubscribe-auth/AH2k8vvlAbG62f8TW8bwAHVnynWQks1Nks5tFJ7VgaJpZM4ROlHa .