search

Cloud-Automation / node-modbus

Modbus TCP Client/Server implementation for Node.JS
466 stars 174 forks source link

add: pass unitId for daisy-chained devices #165

Closed tremendus closed 5 years ago

tremendus commented 6 years ago

Added ability to pass unitId to serial interfaces to support polling daisy-chained devices.

I see no serial tests, none added, fyi

stefanpoeter commented 6 years ago

Thanks for your contribution @tremendus.

I need a unit test before I can merge this.

stefanpoeter commented 6 years ago

@tremendus I really need a unit test. Otherwise I have to close this

tremendus commented 6 years ago

@stefanpoeter Sorry for slow reply. I can write a unit test for this added feature, but I didn't see any serial-based tests in your codebase. Did I miss them?

tremendus commented 6 years ago

Hi @stefanpoeter - I can write a unit test for the added feature, but if I remember correctly, didn't see unit tests for other serial features. Did I miss them?

stefanpoeter commented 6 years ago

Well, that's unfortunate. Since I don't want to add untested code into the main branch I need to add some tests for the serial features. Could take a while, maybe you want take a look at version 3, should be implemented there.