search

Cloud-Automation / node-modbus

Modbus TCP Client/Server implementation for Node.JS
466 stars 174 forks source link

Write multiple coils functionality to v3 TCP server. #172

Closed AnthonyMujic closed 6 years ago

stefanpoeter commented 6 years ago

I've checked the changes. Everythings fine except that the tests for writing multiple coils fails and the buffer utils module should contain BufferUtils class with static methods. Fits better to the rest of the code style. I can do it if you want to.

AnthonyMujic commented 6 years ago

Sounds good to me. What is the workflow from here? Do I cancel the pull request, make the commented changes, then do another pull request?

On Sun, Feb 11, 2018 at 8:58 AM, Stefan Poeter notifications@github.com wrote:

I've checked the changes. Everythings fine except that the tests for writing multiple coils fails and the buffer utils module should contain BufferUtils class with static methods. Fits better to the rest of the code style. I can do it if you want to.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Cloud-Automation/node-modbus/pull/172#issuecomment-364698109, or mute the thread https://github.com/notifications/unsubscribe-auth/AH2k8nifkx55F0OfKNfF1MiiBrzLgZHLks5tThEQgaJpZM4SBFTV .

stefanpoeter commented 6 years ago

Simply make the changes in the responding repository, commit and push the changes