Closed mainstreetmark closed 5 years ago
Something that bothers me is that I didn't pay much attention on the array/buffer mixup in the response and request bodies. But there is no easy way to fix that without breaking some APIs.
The inconsistent naming should actually representing the naming in the specification, though I musst admit that doesn't worked out very well.
I am always happy to accept pull requests if it really bothers you that much, but keep in mind that the old APIs musst stay. They can be marked as deprecated thou.
I think you can leave the existing fields as is (for compatibility) but also decide on a consistent response. For example, include _byteCount
in both responses, even though one also has _numberOfBytes
. And in the docs, just stop referencing _numberOfBytes
.
FC1:
FC4
One has
_coils
, the other_values
. Why not both values? (though,_valuesAsArray
helps). One has_numberOfBytes
, one has_byteCount
. One has_bufferLength
, the other doesn't at all.Consistent responses would make it easer to work with.