search

Cloud-Automation / node-modbus

Modbus TCP Client/Server implementation for Node.JS
471 stars 175 forks source link

Code refactor germanbluefox #82

Closed stefanpoeter closed 7 years ago

stefanpoeter commented 7 years ago

Holly Molly,

@GermanBluefox.

I just let this Link here for you to inspect the meaning of the word concern (in the context of software). Hopefully you get the wink ;-)

I summed up all the pull requests that made changes on the code concerning the code readability.

stefanpoeter commented 7 years ago

The way I see it this can be merged directly. Since there are no actual functional changes I won't make it a new version. But comming versions can build up on this. First thing in the morning!

GermanBluefox commented 7 years ago

I wrote you that I dont know how to do it. And now it is still a question for me. But what have you done, is exactly what I wanted. :)

stefanpoeter commented 7 years ago

If you asked first then you could have saved yourself some time :-)

In this case I collected your pull requests, made every pull request a branch and merged them to a new branch. Pushed this new branch to be a new pull requests.

For your own projects and for future additions here read this. If you are having trouble with git commands, here is a very good visual tutorial about git branching and stuff.

Keep up the good work :-)

GermanBluefox commented 7 years ago

For your own projects and for future additions here read this.

thanks.