search

Cloud-Automation / node-modbus

Modbus TCP Client/Server implementation for Node.JS
471 stars 175 forks source link

Promise.defer is deprecated #96

Closed SystemParadox closed 7 years ago

SystemParadox commented 7 years ago

Node 6 prints lots of warnings to the console:

(node:7143) Warning: Promise.defer is deprecated and will be removed in a future version. Use new Promise instead.

Any chance this could be updated?

Thanks.

stefanpoeter commented 7 years ago

I'll fix this on the next update (2.0.1). Could be a few days though.

psorowka commented 7 years ago

ah.. @SystemParadox how did you produce these warnings? I didn't see any of them when switching to that.

Actually I knew it would be deprecated but I figured the chances that @BauchBeinePoe accepts the PR is higher when I don't completely change everything :-D

@BauchBeinePoe I can file a PR for that later today. It is my fault anyway :)

stefanpoeter commented 7 years ago

@psorowka It's alright. I already fixed it. I'll publish a PR later.

stefanpoeter commented 7 years ago

@SystemParadox can you check if your warnings are still there with the v2.0.1-Release Pull Request?

SystemParadox commented 7 years ago

Warnings are gone. Looks good to me. Thanks :)

stefanpoeter commented 7 years ago

See #98