search

Cloud-CNC / cura-wasm

Cura Engine powered by Web Assembly (WASM)
https://cloud-cnc.github.io
Other
61 stars 17 forks source link

Types definition point to inexistent folder #9

Closed brunobasto closed 3 years ago

brunobasto commented 3 years ago

Hello! Me again :)

https://github.com/Cloud-CNC/cura-wasm/blob/master/package.json#L7

I couldn't find cura-wasm/dist/types inside my node_modules. VSCode gives me compilation errors.

Wakeful-Cloud commented 3 years ago

Hmm that's odd. Are you still running V1.3.3?

brunobasto commented 3 years ago

Yes. Just checked. It's still 1.3.3. For me, there's no types folder inside dist:

Screen Shot 2020-11-30 at 8 32 53 PM

I noticed this yesterday because I'm migrating my little project to typescript (while it's still small 🤣 )

Wakeful-Cloud commented 3 years ago

The types live inside of the cjs and es directories. Currently, the package.json points to the nonexistent types directory but this will be fixed very soon. In the meantime, you can change the "types" field in Cura WASM's package.json to "types": "dist/es/index.d.ts",.

Wakeful-Cloud commented 3 years ago

Please update to version 1.4.2 - switched to named exports, separated definitions to separate package (cura-wasm-definitions), and fixed the package.json issues. Apologies for the confusion and thanks for filing.

brunobasto commented 3 years ago

Awesome. Thank you