Cloud-CV / EvalAI-ngx

Revamped codebase of EvalAI Frontend

BSD 3-Clause "New" or "Revised" License

33 stars 61 forks source link

Add and fix the clock timer on the submit page when submission limit exhausted #179

Closed Sanji515 closed 5 years ago

Sanji515 commented 5 years ago

Changes proposed in this pull request:

Added the clock and fix the implementation to work dynamically
Added the case when the max submissions exceeded
Link to live demo: http://pr-179-evalai.surge.sh

Screenshot 1:

Screenshot from 2019-07-18 14-54-29

Screenshot 1:

Screenshot from 2019-07-18 14-54-59

codecov-io commented 5 years ago

Codecov Report

Merging #179 into master will decrease coverage by 0.31%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   53.36%   53.04%   -0.32%     
==========================================
  Files          59       59              
  Lines        2989     3007      +18     
  Branches      333      337       +4     
==========================================
  Hits         1595     1595              
- Misses       1311     1329      +18     
  Partials       83       83

Impacted Files	Coverage Δ
...lenge/challengesubmit/challengesubmit.component.ts	`31.35% <0%> (-3.38%)`	:arrow_down:

Impacted Files	Coverage Δ
...lenge/challengesubmit/challengesubmit.component.ts	`31.35% <0%> (-3.38%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5fdc7d2...448b6e7. Read the comment docs.

Sanji515 commented 5 years ago

@RishabhJain2018 @lunayach @Shekharrajak @galipremsagar

Please review

lunayach commented 5 years ago

Should we include a soft-check so that the host may not enter Max number of submissions/day > Max number of submissions/month > Max total submissions?

Sanji515 commented 5 years ago

Should we include a soft-check so that the host may not enter Max number of submissions/day > Max number of submissions/month > Max total submissions

@lunayach Yeah it will be good to have. How about opening a new issue for this and will work on this later?

cc: @RishabhJain2018

RishabhJain2018 commented 5 years ago

yes, let's incorporate it in the new PR. @Sanji515 Please open an issue here to keep track of it. cc: @lunayach

RishabhJain2018 commented 5 years ago

Just that, the no. of remaining submissions update only on the page refresh. Should we also open an issue for it?

Page refresh or by clicking the phase?

lunayach commented 5 years ago

Just that, the no. of remaining submissions update only on the page refresh. Should we also open an issue for it?

Page refresh or by clicking the phase?

Page refresh does it or I have to click the radio buttons assigned to different phases (including the one for which I submitted).

RishabhJain2018 commented 5 years ago

yes, that is fine for now.