Cloud-CV / EvalAI-ngx

Revamped codebase of EvalAI Frontend
BSD 3-Clause "New" or "Revised" License
33 stars 61 forks source link

Adding google scholar field and 2 other #232

Closed Suryansh5545 closed 4 years ago

Suryansh5545 commented 4 years ago

Changes proposed in this pull request:- Added Google scholar and other field in profile page

-added 3 input field for google scholar , linkedin , github.

- evalai-ngx profile

codecov-io commented 4 years ago

Codecov Report

Merging #232 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   51.73%   51.73%           
=======================================
  Files          66       66           
  Lines        3659     3659           
  Branches      413      413           
=======================================
  Hits         1893     1893           
  Misses       1671     1671           
  Partials       95       95
Impacted Files Coverage Δ
src/app/components/profile/profile.component.ts 51.25% <ø> (ø) :arrow_up:
Impacted Files Coverage Δ
src/app/components/profile/profile.component.ts 51.25% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b03bdc4...f107c3c. Read the comment docs.

Suryansh5545 commented 4 years ago

I fix the indent issue and removed unnecessary lines

Suryansh5545 commented 4 years ago

i am opening new pr