Closed Suryansh5545 closed 4 years ago
Merging #242 into master will decrease coverage by
0.2%
. The diff coverage is8%
.
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
- Coverage 51.07% 50.87% -0.21%
==========================================
Files 66 66
Lines 3716 3731 +15
Branches 431 438 +7
==========================================
Hits 1898 1898
- Misses 1723 1738 +15
Partials 95 95
Impacted Files | Coverage Δ | |
---|---|---|
...lenge/challengesubmit/challengesubmit.component.ts | 28.09% <8%> (-2.17%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
...lenge/challengesubmit/challengesubmit.component.ts | 28.09% <8%> (-2.17%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bcba4e9...4e69f52. Read the comment docs.
@Suryansh5545 Can you please resolve conflicts here?
@Suryansh5545 For consistency purpose, can we show these (^) three things at the page load instead of just Select phase
option?
Sir as you said phase selection is necessary and if phase is selected first then it is better because if I am right it is shown later after selecting phase that how many submission are left. And other things and also it gives it a good look .
i have made the changes
Hey @Suryansh5545 Still Submission option is not aligned with the Select phase options. And also I'm unable to make submission, it gives me error on the browser, please look to it.
sir i cant understand how submission option should be aligned with the select phase
I think giving some margin to the left would be fine :)
sir is the error about: Cannot read property 'fileboxchecked' of undefined
sir is the error about: Cannot read property 'fileboxchecked' of undefined
Yes, can you please fix this?
i already tried it but i cant understand why the error is coming as the fileboxchecked is a Boolean and is already defined and assigned a value . so how it cant read the value .
i have fixed the issue but is it normal for console to show this error if i give it a google drive url error :- POST http://localhost:8000/api/jobs/challenge/1/challenge_phase/2/submission/ 500 (Internal Server Error)
indeed the error is because i am running an internal server
i have removed those htmlelements
i have also made the submit button go disable after a successful submit , so user will be unable to toy around with it. but if bypassed the formsubmit will show its own error
Hey, currently if I make submissions using URL it's saying Please upload file
@Suryansh5545 Please fix this.
Sir i tried to reproduce the error but it shows error of Something went wrong . but i am unable to get "Please upload file" error message . So if possible can you provide me with a image?
Sir i tried to reproduce the error but it shows error of Something went wrong . but i am unable to get "Please upload file" error message . So if possible can you provide me with a image?
Again the same case, try switching back from upload file to submission using url and then submit :)
Sir i am unable to resolve the issue this is my code to check and execute if statement of "Please upload file"
i checked in log and the value of isSubmissionUsingUrl is true . i also tried !self.isSubmissionUsingUrl
but it is same. As per the code the if statement should not be executed. If value of isSubmissionUsingUrl is true
i have fixed the issues
All changes done
i have completed all changes sir
Changes proposed in this pull request:
-Added Url field for submission on front-end
-