Cloud-CV / EvalAI-ngx

Revamped codebase of EvalAI Frontend
BSD 3-Clause "New" or "Revised" License
33 stars 61 forks source link

[GCI]Add Url Submission for large file #242

Closed Suryansh5545 closed 4 years ago

Suryansh5545 commented 4 years ago

Changes proposed in this pull request:

-Added Url field for submission on front-end

- Selection_032

codecov-io commented 4 years ago

Codecov Report

Merging #242 into master will decrease coverage by 0.2%. The diff coverage is 8%.

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
- Coverage   51.07%   50.87%   -0.21%     
==========================================
  Files          66       66              
  Lines        3716     3731      +15     
  Branches      431      438       +7     
==========================================
  Hits         1898     1898              
- Misses       1723     1738      +15     
  Partials       95       95
Impacted Files Coverage Δ
...lenge/challengesubmit/challengesubmit.component.ts 28.09% <8%> (-2.17%) :arrow_down:
Impacted Files Coverage Δ
...lenge/challengesubmit/challengesubmit.component.ts 28.09% <8%> (-2.17%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bcba4e9...4e69f52. Read the comment docs.

Sanji515 commented 4 years ago

@Suryansh5545 Can you please resolve conflicts here?

Sanji515 commented 4 years ago

Screenshot from 2019-12-18 01-29-39

@Suryansh5545 For consistency purpose, can we show these (^) three things at the page load instead of just Select phase option?

Suryansh5545 commented 4 years ago

Sir as you said phase selection is necessary and if phase is selected first then it is better because if I am right it is shown later after selecting phase that how many submission are left. And other things and also it gives it a good look .

Suryansh5545 commented 4 years ago

i have made the changes

Sanji515 commented 4 years ago

Hey @Suryansh5545 Still Submission option is not aligned with the Select phase options. And also I'm unable to make submission, it gives me error on the browser, please look to it.

Sanji515 commented 4 years ago

sir i cant understand how submission option should be aligned with the select phase

I think giving some margin to the left would be fine :)

Suryansh5545 commented 4 years ago

sir is the error about: Cannot read property 'fileboxchecked' of undefined

Sanji515 commented 4 years ago

sir is the error about: Cannot read property 'fileboxchecked' of undefined

Yes, can you please fix this?

Suryansh5545 commented 4 years ago

i already tried it but i cant understand why the error is coming as the fileboxchecked is a Boolean and is already defined and assigned a value . so how it cant read the value .

Suryansh5545 commented 4 years ago

i have fixed the issue but is it normal for console to show this error if i give it a google drive url error :- POST http://localhost:8000/api/jobs/challenge/1/challenge_phase/2/submission/ 500 (Internal Server Error)

Suryansh5545 commented 4 years ago

indeed the error is because i am running an internal server

Suryansh5545 commented 4 years ago

i have removed those htmlelements

Suryansh5545 commented 4 years ago

i have also made the submit button go disable after a successful submit , so user will be unable to toy around with it. but if bypassed the formsubmit will show its own error

Sanji515 commented 4 years ago

Hey, currently if I make submissions using URL it's saying Please upload file @Suryansh5545 Please fix this.

Suryansh5545 commented 4 years ago

Sir i tried to reproduce the error but it shows error of Something went wrong . but i am unable to get "Please upload file" error message . So if possible can you provide me with a image?

Sanji515 commented 4 years ago

Sir i tried to reproduce the error but it shows error of Something went wrong . but i am unable to get "Please upload file" error message . So if possible can you provide me with a image?

Again the same case, try switching back from upload file to submission using url and then submit :)

Suryansh5545 commented 4 years ago

Sir i am unable to resolve the issue this is my code to check and execute if statement of "Please upload file" Selection_055

i checked in log and the value of isSubmissionUsingUrl is true . i also tried !self.isSubmissionUsingUrl

but it is same. As per the code the if statement should not be executed. If value of isSubmissionUsingUrl is true

Suryansh5545 commented 4 years ago

i have fixed the issues

Suryansh5545 commented 4 years ago

All changes done

Suryansh5545 commented 4 years ago

i have completed all changes sir