drepram commented 4 years ago

I'm going to make this clear. I'm not going to claim that I did all of the parts in this PR, major changes were created by https://github.com/Suryansh5545. What I did was help out by cleaning out some logs, renamed some variables, and fixed the logic.

I visibly forked the repo from his account and not Cloud-CV's.

Changes proposed in this pull request:

There was a problem:

When you change the URL of a social field, the submit button wouldn't be triggered. You have to change a part of the identification field {first_name, last_name, affiliation}.

I fixed this by adding conditions that would allow the submit button to be triggered, and at the same time also validating them using a simple DOM method.

Add URL verification
Fix bug where modification of social fields wouldn't trigger a submission
Link to live demo: http://pr-243-evalai.surge.sh

codecov-io commented 4 years ago

Codecov Report

Merging #243 into master will decrease coverage by 0.37%. The diff coverage is 10.81%.

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   51.45%   51.07%   -0.38%     
==========================================
  Files          66       66              
  Lines        3681     3716      +35     
  Branches      422      431       +9     
==========================================
+ Hits         1894     1898       +4     
- Misses       1692     1723      +31     
  Partials       95       95

Impacted Files	Coverage Δ
src/app/components/profile/profile.component.ts	`48.23% <ø> (+0.56%)`	:arrow_up:
...rc/app/components/utility/modal/modal.component.ts	`28.87% <10.81%> (-6.04%)`	:arrow_down:

Impacted Files	Coverage Δ
src/app/components/profile/profile.component.ts	`48.23% <ø> (+0.56%)`	:arrow_up:
...rc/app/components/utility/modal/modal.component.ts	`28.87% <10.81%> (-6.04%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 78ea56d...6d1af5b. Read the comment docs.

Sanji515 commented 4 years ago

After entering the 2 valid url if I enter last url invalid then it shows URL invalid error message to all the three fields, this is happening as you are using inputErrorMessage to display message which is same for all the input. @drepram Please fix this.

drepram commented 4 years ago