Cloud-CV / EvalAI-ngx

Revamped codebase of EvalAI Frontend
BSD 3-Clause "New" or "Revised" License
33 stars 61 forks source link

Inconsistency in EvalAI-ngx. #255

Open jayaike opened 4 years ago

jayaike commented 4 years ago

I'm submitting a

(Check one with "x" from given options)

Current behavior

I noticed that in the EvalAI-ngx sometimes "state-of-the-art" is used, other times "state of the art" is used.

Expected behavior

Either "state of the art" or "state-of-the-art" should be used.

Which one should we use so we don't make it look inconsistent and I can make a pull request for it?

jayaike commented 4 years ago

@Sanji515 @pushkalkatara @vkartik97 @Ram81 @RishabhJain2018

jayaike commented 4 years ago

state-of-the-art was used in :

about.component.html line 10 get-involved.component.html line 11 home.component.html line 3

state of the art was used in

footer.component.html line 6 homemain.component.html line 3 auth.component.html line 27

@Suryansh5545

Suryansh5545 commented 4 years ago

Yea i Saw it Now.

krtkvrm commented 4 years ago

@nsjcorps thanks for reporting this. If you are interested in fixing this issue, please let me know.

jayaike commented 4 years ago

I created a PR for it already @vkartik97

https://github.com/Cloud-CV/EvalAI-ngx/pull/261

jayaike commented 4 years ago

I think you should also take a look at https://github.com/Cloud-CV/EvalAI-ngx/pull/256 @vkartik97