Closed Suryansh5545 closed 4 years ago
Merging #260 into master will decrease coverage by
0.02%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 50.72% 50.69% -0.03%
==========================================
Files 66 66
Lines 3744 3744
Branches 440 440
==========================================
- Hits 1899 1898 -1
- Misses 1750 1751 +1
Partials 95 95
Impacted Files | Coverage Δ | |
---|---|---|
...bliclists/challengelist/challengelist.component.ts | 46.66% <0%> (-0.96%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
...bliclists/challengelist/challengelist.component.ts | 46.66% <0%> (-0.96%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a609ece...696a5eb. Read the comment docs.
Why is it called Updated CONTRIBUTING.md
instead of just CONTRIBUTING.md
?
I don't know this I just updated url
Maybe this is for some other purpose
@Suryansh5545 I don't think this is a typo. The command is intended to keep the origin branch in touch with the updates going on in the main Cloud-CV/EvalAI repo.
On Sun, Jan 5, 2020, 14:31 Suryansh5545 notifications@github.com wrote:
Maybe this is for some other purpose
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Cloud-CV/EvalAI-ngx/pull/260?email_source=notifications&email_token=AI7MKYN65H3HPIUTPTQ2BC3Q4GOXJA5CNFSM4KCZ5RSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIDRXJQ#issuecomment-570891174, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7MKYNKX2UZPQAT7H47YLDQ4GOXJANCNFSM4KCZ5RSA .
@nikochiko The line I have edited is about adding a remote to submit the code . So it is quite obvious that the user will need to first push it on his own repo instead of adding the main EvalAI-ngx repo . On which he wouldn't have a write access
@Suryansh5545 I think you misunderstood it there. The branch we are creating is to make changes on it (and maybe, submit the code). But, the upstream we are adding here is so that our fork remains in sync with the main master from Cloud-CV. So, if you have already forked, and already checked out the branch you want to work on, you can run this command and anytime an update is made on Cloud-CV:master, you can fetch or pull it instantly. You can refer to this guide: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/configuring-a-remote-for-a-fork
Yea you are right . I misunderstood it
Replaced Cloud-CV with YOUR-USERNAME. As the person submitting the code will be first pushing it into his own repo first instead of evalai main repo