search

Cloud-CV / EvalAI-ngx

Revamped codebase of EvalAI Frontend
BSD 3-Clause "New" or "Revised" License
33 stars 61 forks source link

Add a soft check when editing phase details #265

Open nikochiko opened 4 years ago

nikochiko commented 4 years ago

As part of a Google Code-In task.

Changes proposed in this pull request:

codecov-io commented 4 years ago

Codecov Report

Merging #265 into master will decrease coverage by 0.1%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   50.62%   50.51%   -0.11%     
==========================================
  Files          66       66              
  Lines        3761     3771      +10     
  Branches      442      444       +2     
==========================================
+ Hits         1904     1905       +1     
- Misses       1762     1771       +9     
  Partials       95       95
Impacted Files Coverage Δ
...ephases/editphasemodal/editphasemodal.component.ts 33.76% <0%> (-5.04%) :arrow_down:
...bliclists/challengelist/challengelist.component.ts 47.61% <0%> (+0.95%) :arrow_up:
Impacted Files Coverage Δ
...ephases/editphasemodal/editphasemodal.component.ts 33.76% <0%> (-5.04%) :arrow_down:
...bliclists/challengelist/challengelist.component.ts 47.61% <0%> (+0.95%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e81fb10...2a90aa2. Read the comment docs.

nikochiko commented 4 years ago

@Ram81 I am facing this issue for the dev build :confused: https://github.com/Cloud-CV/EvalAI-ngx/issues/249. Can you please share if there is any other way to test the working?

(Not linking issue directly as it could create reference to the unrelated issue)