search

Cloud-CV / EvalAI-ngx

Revamped codebase of EvalAI Frontend
BSD 3-Clause "New" or "Revised" License
33 stars 61 forks source link

Fix:#266 Fixed two scroll up buttons in privacy page #267

Closed Suryansh5545 closed 4 years ago

Suryansh5545 commented 4 years ago

Fix:#266 Removed the earlier scroll up button

codecov-io commented 4 years ago

Codecov Report

Merging #267 into master will increase coverage by 0.01%. The diff coverage is 40%.

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   50.63%   50.65%   +0.01%     
==========================================
  Files          66       66              
  Lines        3764     3769       +5     
  Branches      442      444       +2     
==========================================
+ Hits         1906     1909       +3     
- Misses       1763     1765       +2     
  Partials       95       95
Impacted Files Coverage Δ
...rc/app/components/challenge/challenge.component.ts 87.85% <100%> (ø) :arrow_up:
...e/challengesettings/challengesettings.component.ts 45.16% <33.33%> (-0.46%) :arrow_down:
...bliclists/challengelist/challengelist.component.ts 47.57% <0%> (+0.97%) :arrow_up:
Impacted Files Coverage Δ
...rc/app/components/challenge/challenge.component.ts 87.85% <100%> (ø) :arrow_up:
...e/challengesettings/challengesettings.component.ts 45.16% <33.33%> (-0.46%) :arrow_down:
...bliclists/challengelist/challengelist.component.ts 47.57% <0%> (+0.97%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c1a505e...df2de82. Read the comment docs.

drepram commented 4 years ago

Hey Surya, the branch is out of date. You should fix it before the mentors see it so that this PR could be merged faster.