search

Cloud-CV / EvalAI-ngx

Revamped codebase of EvalAI Frontend
BSD 3-Clause "New" or "Revised" License
33 stars 61 forks source link

Use of Route Guards as opposed to in-component Redirects #271

Open jayaike opened 4 years ago

jayaike commented 4 years ago

I'm submitting a

(Check one with "x" from given options)

Current behavior

The project allows users to navigate to protected routes and then Redirects to an appropriate route based on authentication status. This method causes this bandicam-2020-01-15-07-01-01-050_Trim

As we can see it shows the user the "protected route before redirect"

Expected behavior

The project should make use of Route Guards using CanActivate. This way we will follow the DRY principle of coding

I have started working on this

jayaike commented 4 years ago

I will like to work on the issue along with the Lazy Loading Modules issue I created @vkartik97 @RishabhJain2018 @Ram81 @yashdusing @Sanji515

Sanji515 commented 4 years ago

sure! @nsjcorps , go ahead