Add sidebar to Challenge page

[jayaike]

I have added the sidebar to the challenge page as described in other pages

Screenshots

After Login

Before Login

GCI Task: https://codein.withgoogle.com/dashboard/task-instances/6659470118092800/

[jayaike]

What am I to fix? @Sanji515

[Sanji515]

What am I to fix? @Sanji515

Background color is not applied to whole mid-container instead it has some margin to the left and right.

[jayaike]

What is it supposed to look like @Sanji515

[Sanji515]

What is it supposed to look like @Sanji515

Same as in the current version (here)

[jayaike]

Just did it @Sanji515

[Sanji515]

Just did it @Sanji515

Hey it doesn't look same (challenge card width).

I would suggest you to add background-color: #fafafa to the body tag in styles/base.scss and remove the background-color from all the parent component. @nsjcorps what do you say? Try checking this change if this works.

[jayaike]

As for the background color @Sanji515 . I would say that would be rather complex for this task because other changes will be involved

[jayaike]

The GCI task was more about setting the sidebar in the challenge page

[Sanji515]

As for the background color @Sanji515 . I would say that would be rather complex for this task because other changes will be involved

yeah but with this change it doesn't look good. At least you can give a try (just add the background in the body in base.scss and remove from all other parent component). Lets just see if this will work or not.

[jayaike]

Sorry @Sanji515 I was supposed to divide 223px by 2. Which I have done now.

[jayaike]

Change has been made @Sanji515

As for the background color @Sanji515 . I would say that would be rather complex for this task because other changes will be involved

yeah but with this change it doesn't look good. At least you can give a try (just add the background in the body in base.scss and remove from all other parent component). Lets just see if this will work or not.

[Sanji515]

Change has been made @Sanji515

Have you tested on your local?

[jayaike]

I tested but I can't test all routes because of my docker issue and my laptop issue but as for the challenge one it is good

[jayaike]

We seem to be going in circles @Sanji515

[jayaike]

@Sanji515 :)....I did the background change and i reverted the other file

[Sanji515]

We seem to be going in circles @Sanji515

I think we came a long way @nsjcorps :smile:

[jayaike]

We seem to be going in circles @Sanji515

I think we came a long way @nsjcorps 😄

Oh yes we did!

[jayaike]

Thanks @nsjcorps you did a great job 👍 LGTM! This can be merged now 🎉

Thank you....63 commits and 171 + 1 comments 😂😂

I have submitted the GCI task for review

[jayaike]

I think I just did the 100th task. That has got to be a Landmark 🎉🎉🎉🎉🎉

[Sanji515]

@nsjcorps Can you please resolve conflicts and update the PR description here?

[jayaike]

What should I update the PR description to? @Sanji515 Sorry, I am just seeing this.

[Sanji515]

What should I update the PR description to? @Sanji515 Sorry, I am just seeing this.

Current screenshot showing the sidebar when user is not logged in but in our latest commit the sidebar should come after login and not before login.

[jayaike]

Hi @Sanji515 , unfortunately I cannot log in to the evalai-ngx Dev environment. Can you take the screenshots on your end and give them to me so I can update them. It would be highly appreciated 😁😁

[Sanji515]

Hi @Sanji515 , unfortunately I cannot log in to the evalai-ngx Dev environment. Can you take the screenshots on your end and give them to me so I can update them. It would be highly appreciated

No worries @nsjcorps , I've updated your PR description with the screenshots.

[jayaike]

Thanks @Sanji515