search

Cloud-CV / EvalAI-ngx

Revamped codebase of EvalAI Frontend
BSD 3-Clause "New" or "Revised" License
33 stars 61 forks source link

Auth guards #282

Open jayaike opened 4 years ago

jayaike commented 4 years ago

Fixes # https://github.com/Cloud-CV/EvalAI-ngx/issues/271

Changes proposed in this pull request:

Previously:

bandicam-2020-01-15-07-01-01-050_Trim

Currently:

routeguard

jayaike commented 4 years ago

@Sanji515 Please take a look

jayaike commented 4 years ago

@Ram81 @RishabhJain2018 @vkartik97 PTAL

codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a74e917). Click here to learn what that means. The diff coverage is 31.91%.

@@            Coverage Diff            @@
##             master     #282   +/-   ##
=========================================
  Coverage          ?   50.63%           
=========================================
  Files             ?       66           
  Lines             ?     3768           
  Branches          ?      443           
=========================================
  Hits              ?     1908           
  Misses            ?     1766           
  Partials          ?       94
Impacted Files Coverage Δ
...bliclists/challengelist/challengelist.component.ts 47.57% <ø> (ø)
...rc/app/components/dashboard/dashboard.component.ts 90.9% <ø> (ø)
...bmissions/challengeviewallsubmissions.component.ts 31.73% <100%> (ø)
...rc/app/components/challenge/challenge.component.ts 87.85% <14.28%> (ø)
src/app/app.component.ts 35.21% <25%> (ø)
...e/challengesettings/challengesettings.component.ts 45.16% <33.33%> (ø)
...lengeleaderboard/challengeleaderboard.component.ts 34.07% <33.33%> (ø)
src/app/services/endpoints.service.ts 64.89% <50%> (ø)
Impacted Files Coverage Δ
...bliclists/challengelist/challengelist.component.ts 47.57% <ø> (ø)
...rc/app/components/dashboard/dashboard.component.ts 90.9% <ø> (ø)
...bmissions/challengeviewallsubmissions.component.ts 31.73% <100%> (ø)
...rc/app/components/challenge/challenge.component.ts 87.85% <14.28%> (ø)
src/app/app.component.ts 35.21% <25%> (ø)
...e/challengesettings/challengesettings.component.ts 45.16% <33.33%> (ø)
...lengeleaderboard/challengeleaderboard.component.ts 34.07% <33.33%> (ø)
src/app/services/endpoints.service.ts 64.89% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a74e917...02a743f. Read the comment docs.