Open Kajol-Kumari opened 4 years ago
Merging #316 into master will increase coverage by
0.02%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #316 +/- ##
==========================================
+ Coverage 50.63% 50.66% +0.02%
==========================================
Files 66 66
Lines 3772 3774 +2
Branches 444 444
==========================================
+ Hits 1910 1912 +2
Misses 1767 1767
Partials 95 95
Impacted Files | Coverage Δ | |
---|---|---|
src/app/app.component.ts | 36.98% <100.00%> (+1.77%) |
:arrow_up: |
Impacted Files | Coverage Δ | |
---|---|---|
src/app/app.component.ts | 36.98% <100.00%> (+1.77%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2b9f2bf...6e662a2. Read the comment docs.
@Shekharrajak Can you please review this again?
@Kajol-Kumari , can you please provide some description how this PR will work and perform better ? Can you make sure you write details in PR itself ? Adding comments to your code change will help to approve and understand it better.
Merging #316 into master will increase coverage by
0.02%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #316 +/- ##
==========================================
+ Coverage 50.16% 50.19% +0.02%
==========================================
Files 66 66
Lines 3873 3875 +2
Branches 450 450
==========================================
+ Hits 1943 1945 +2
Misses 1836 1836
Partials 94 94
Impacted Files | Coverage Δ | |
---|---|---|
src/environments/environment.staging.ts | 100.00% <ø> (ø) |
|
src/environments/environment.ts | 100.00% <ø> (ø) |
|
src/app/app.component.ts | 36.98% <100.00%> (+1.77%) |
:arrow_up: |
Impacted Files | Coverage Δ | |
---|---|---|
src/environments/environment.staging.ts | 100.00% <ø> (ø) |
|
src/environments/environment.ts | 100.00% <ø> (ø) |
|
src/app/app.component.ts | 36.98% <100.00%> (+1.77%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 932a9c0...1700876. Read the comment docs.
@Kajol-Kumari , can you please provide some description how this PR will work and perform better ? Can you make sure you write details in PR itself ? Adding comments to your code change will help to approve and understand it better.
@Shekharrajak I have added the required description and comments.can u please review it now.
Feature added:
The cookie consent will appear when-
someone opens the site for the first time
everytime when someone opens the site in incognito window
Screenshot:
For tablets:
Mobile view: