Cloud-CV / EvalAI-ngx

Revamped codebase of EvalAI Frontend
BSD 3-Clause "New" or "Revised" License
33 stars 61 forks source link

Added cookie consent #316

Open Kajol-Kumari opened 4 years ago

Kajol-Kumari commented 4 years ago

Feature added:

The cookie consent will appear when-

Screenshot: Screenshot from 2020-05-28 21-46-17

For tablets: Screenshot from 2020-05-28 21-45-50

Mobile view: Screenshot from 2020-05-28 21-49-28

codecov-io commented 4 years ago

Codecov Report

Merging #316 into master will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
+ Coverage   50.63%   50.66%   +0.02%     
==========================================
  Files          66       66              
  Lines        3772     3774       +2     
  Branches      444      444              
==========================================
+ Hits         1910     1912       +2     
  Misses       1767     1767              
  Partials       95       95              
Impacted Files Coverage Δ
src/app/app.component.ts 36.98% <100.00%> (+1.77%) :arrow_up:
Impacted Files Coverage Δ
src/app/app.component.ts 36.98% <100.00%> (+1.77%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b9f2bf...6e662a2. Read the comment docs.

RishabhJain2018 commented 4 years ago

@Shekharrajak Can you please review this again?

Shekharrajak commented 4 years ago

@Kajol-Kumari , can you please provide some description how this PR will work and perform better ? Can you make sure you write details in PR itself ? Adding comments to your code change will help to approve and understand it better.

codecov-commenter commented 4 years ago

Codecov Report

Merging #316 into master will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
+ Coverage   50.16%   50.19%   +0.02%     
==========================================
  Files          66       66              
  Lines        3873     3875       +2     
  Branches      450      450              
==========================================
+ Hits         1943     1945       +2     
  Misses       1836     1836              
  Partials       94       94              
Impacted Files Coverage Δ
src/environments/environment.staging.ts 100.00% <ø> (ø)
src/environments/environment.ts 100.00% <ø> (ø)
src/app/app.component.ts 36.98% <100.00%> (+1.77%) :arrow_up:
Impacted Files Coverage Δ
src/environments/environment.staging.ts 100.00% <ø> (ø)
src/environments/environment.ts 100.00% <ø> (ø)
src/app/app.component.ts 36.98% <100.00%> (+1.77%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 932a9c0...1700876. Read the comment docs.

Kajol-Kumari commented 4 years ago

@Kajol-Kumari , can you please provide some description how this PR will work and perform better ? Can you make sure you write details in PR itself ? Adding comments to your code change will help to approve and understand it better.

@Shekharrajak I have added the required description and comments.can u please review it now.