search

Cloud-CV / EvalAI

:cloud: :rocket: :bar_chart: :chart_with_upwards_trend: Evaluating state of the art in AI
https://eval.ai
Other
1.77k stars 787 forks source link

Determine why code coverage is low #2028

Open RishabhJain2018 opened 5 years ago

RishabhJain2018 commented 5 years ago

Current Behaviour

The code coverage is 72% which is quite low.

Expected Behaviour

The code coverage should be > 90%.

Deliverable

KhalidRmb commented 5 years ago

I would like to work on this one. @RishabhJain2018

RishabhJain2018 commented 5 years ago

Sure! You can take this up.

krtkvrm commented 5 years ago

@RishabhJain2018 @KhalidRmb #1997 is related to this issue.

RishabhJain2018 commented 5 years ago

Thanks, @vkartik97 for mentioning it. @KhalidRmb Please do take a note of it in the doc you are preparing.

KhalidRmb commented 5 years ago

@RishabhJain2018 Link to Google doc with a checklist of all the relevant unit tests to be written: https://docs.google.com/document/d/1IF3APjd93hUeov4KKRGDupMlcjpLO-MYo3_lEP8e42k/edit?usp=sharing

KhalidRmb commented 5 years ago

@RishabhJain2018 ..any comments/changes required to the doc?

yongzx commented 5 years ago

@KhalidRmb @RishabhJain2018 I will create an issue and write unit tests for /apps/base/utils.py because #2054 couldn't pass the coverage tests.

yongzx commented 5 years ago

@KhalidRmb Added unit tests for both functions decode_data and encode_data in /apps/base/utils.py #2107

kurianbenoy commented 5 years ago

scripts/workers/submission_worker.py is a major area where Test coverage can be improved @KhalidRmb . I guess python unit tests can do the job for submission worker. Yet we also need to think where Integration tests are missing in apps to increase coverage

01shriyansh commented 3 years ago

i would like to work on this @RishabhJain2018

adithyathecoder commented 2 years ago

i would like to work on this @RishabhJain2018