Cloud-CV / EvalAI

:cloud: :rocket: :bar_chart: :chart_with_upwards_trend: Evaluating state of the art in AI
https://eval.ai
Other
1.76k stars 781 forks source link

[code] Improve code structure for `submission_worker.py` and `remote_submission_worker.py`. #2542

Open nikochiko opened 4 years ago

nikochiko commented 4 years ago

Current:

The submission_worker and remote_submission_worker have a lot in common currently. Naturally, if a change happens in the future, code in both files will have to be edited. In addition to that, many functions are very much exactly the same. Moreover, within each file, there is repetition of code, e.g.: the download_and_extract_file and download_and_extract_zip_file use the same code for the downloading part.

Expected:

The code should be modularized and helper methods / utils should be created accessible to both the workers. This will:

Objective of resolving PR:

@RishabhJain2018 @Ram81 This is my suggestion, please let me know if a PR for this is required. (I am also a GCI participant, so it would be great to have this as a task :D)

sunnykharel commented 4 years ago

Is this problem up for grabs?