search

Cloud-CV / EvalAI

:cloud: :rocket: :bar_chart: :chart_with_upwards_trend: Evaluating state of the art in AI
https://eval.ai
Other
1.76k stars 784 forks source link

[Frontend V2] Logout Button isn't visible in Mobile view #3380

Open ankitpal1029 opened 3 years ago

ankitpal1029 commented 3 years ago

There should be a logout in the mobile view which isn't there currently: image

The logout button could be kept on top or maybe in the burger menu as well image

rijusougata13 commented 3 years ago

can i work on this?

ankitpal1029 commented 3 years ago

@rijusougata13 sure you can just ask @Ram81 once regarding this since i'm not the maintainer

ankitpal1029 commented 3 years ago

@rijusougata13 are you still working on this?

rijusougata13 commented 3 years ago

@ankitpal1029 no i wasn't working on this issue

Manjuphoenix commented 3 years ago

Is the issue still there?

kashish987 commented 3 years ago

@Ram81 Sir I would like to work on this issue .

AaqibAhamed commented 3 years ago

Anyone else working on it ??

kashish987 commented 3 years ago

Yes @AaqibAhamed I am working on it.

AaqibAhamed commented 3 years ago

Yes @AaqibAhamed I am working on it.

As I checked your commit belongs to Fontend not belong to Fontend_V2 .. Name of the issue belongs Fontend_V2 .. Is this followed correctly. @kashish987

kashish987 commented 3 years ago

Yes @AaqibAhamed I am working on it.

As I checked your commit belongs to Fontend not belong to Fontend_V2 .. Name of the issue belongs Fontend_V2 .. Is this followed correctly. @kashish987

@AaqibAhamed As I have manually checked the eval ai code and ran it .The issue was found in Frontend so I have modified it and committed it.

@ankitpal1029 can you please tell that whether this needs to be done in Frontend V2 as well so that I can add that as well since at my end I am able to see that this screen is linked to Frontend.

AaqibAhamed commented 3 years ago

Yes @AaqibAhamed I am working on it.

As I checked your commit belongs to Fontend not belong to Fontend_V2 .. Name of the issue belongs Fontend_V2 .. Is this followed correctly. @kashish987

@AaqibAhamed As I have manually checked the eval ai code and ran it .The issue was found in Frontend so I have modified it and committed it.

@ankitpal1029 can you please tell that whether this needs to be done in Frontend V2 as well so that I can add that as well since at my end I am able to see that this screen is linked to Frontend.

Okay.. Also when we runnig app normally it's using Frontend V2 ..May I know the reason why we it configured like this..Any reason??. @Ram81

ankitpal1029 commented 3 years ago

@kashish987 since we are shifting over to frontend V2 it would be better if you implement it on the same

kashish987 commented 3 years ago

@kashish987 since we are shifting over to frontend V2 it would be better if you implement it on the same

sure will do that. Thanks

AaqibAhamed commented 3 years ago

@kashish987 since we are shifting over to frontend V2 it would be better if you implement it on the same

sure will do that. Thanks

Can you fix that and ammend into your existing PR and mention here. @kashish987

kashish987 commented 3 years ago

Required changes have been done and added to the existing Pull Request.