search

Cloud-CV / Fabrik

:factory: Collaboratively build, visualize, and design neural nets in browser
GNU General Public License v3.0
1.12k stars 235 forks source link

Share button should be disabled when canvas is empty #463

Open gautamjajoo opened 5 years ago

gautamjajoo commented 5 years ago

Observed Behaviour

One can get a shareable link if the canvas is empty.

Expected Behaviour

The share button should be disbaled

Would you like to work on it?

Yes

@Ram81

capture

Ram81 commented 5 years ago

@gautamjajoo sure go ahead.

rshrc commented 5 years ago

Is there a current pull request regarding this feature request?

gautamjajoo commented 5 years ago

@rshrc No, I haven't opened a PR yet, will be doing in some time.

rshrc commented 5 years ago

@gautamjajoo I was learning React, and thought of this as an easy issue, can I work on it? Maybe you can walk me through on how to go about it? I'll get familiar with the code base on the way. If possible obviously.

gautamjajoo commented 5 years ago

@rshrc Ok, you can work on it!