search

Cloud-CV / Fabrik

:factory: Collaboratively build, visualize, and design neural nets in browser
GNU General Public License v3.0
1.12k stars 235 forks source link

Deleting multiple layers issue #317 #485

Closed Gurpreetsingh9465 closed 5 years ago

Gurpreetsingh9465 commented 5 years ago

This is a PR regarding issue #317

  1. multiple layer selection
  2. deletion
  3. confirmation
  4. improved the logic of tracking nextlayer
  5. making sure the the default select layer method does not conflict with this
Gurpreetsingh9465 commented 5 years ago

Right click selects the layer

yashdusing commented 5 years ago

A few issues I've encountered :

  1. If side panel is enabled, selection is not possible.
  2. Selection of layer could be highlighted using some different css techniques. Something like blurring would be good imo. First discuss with @Ram81 about the css.
  3. All caps for the deletion message. Again, consult @Ram81 about this
  4. After deleting a number of layers, the last remaining layer does not track next layer i.e. layer addition does not append layer to last layer
Gurpreetsingh9465 commented 5 years ago

Right now the code is in a way that If sidepane is enabled then you can't select or deselect layers further and the the sidepanel layer is deselected.

Gurpreetsingh9465 commented 5 years ago

The new layer is appending I guess you can see it on the .gif as well can you send me the console output

yashdusing commented 5 years ago

Sorry, I was a little busy. Here you go. screenshot_20181208_004938

yashdusing commented 5 years ago

Steps to recreate :

  1. Load ZFnet
  2. Select random layers from the middle and then delete these layers
  3. Then select one of the 2 remaining sets and delete it.
  4. Now try adding layers
yashdusing commented 5 years ago

Also, please do something about the css. It's hard to keep track of the selected layers

Gurpreetsingh9465 commented 5 years ago

test updated the css

Gurpreetsingh9465 commented 5 years ago

Changes done.