Closed sayamkanwar closed 5 years ago
Added content for the team section.
@Ram81
Hi, I have made the changes. Please review @deshraj @virajprabhu Thank you
@Ram81, made all the changes!
Here's a demo
@Ram81, so no demos for the features?
Is this fine? @utsavgarg @RishabhJain2018
Or would you like something like this? @Ram81 @RishabhJain2018 @utsavgarg
(The GIF would be in the place of the image)
If I may add to the discussion, how about GIFs that have a translucent play button on them and play when you hover on them
@PalashTanejaPro Thanks for the suggestion, but I guess that would be a little out of place because these GIFs were being triggered by clicking on a feature box. So even after once the user has clicked the box, a play button is required? I can add it but it might spoil the user experience.
@PalashTanejaPro Oh I'm really sorry I misinterpreted your suggestion, that will be a very good feature to be incorporated and will prevent the GIF from being missed by the user. I'll try to include it. Thanks a lot for the suggestion! :)
Hey, I've changed the design of the demo and added the feature which @PalashTanejaPro had asked for. Please have a look at it here @Ram81 @RishabhJain2018 @utsavgarg:
Thank you! :)
@Ram81 Oh I'm really sorry, I'll fix it.
Is this fine? @Ram81
@Ram81 Changed the design to what you asked for. I hope it's fine now?
Is this what you want? @Ram81
Actually, alignment was still a bit messed up, I have corrected it now, @Ram81. Here:
Sure @Ram81
@Ram81, the homepage would be available at /#/home. :)
@Ram81, please check now.
The page looks good for a start. Thanks, @sayamkanwar for putting in a lot of effort. Here are some comments:
Font color of
Fabrik
is not the same as the color of other fonts in the theme.
Please try Roboto Font.
Whenever I click on features Tab in the header it didn't scroll me to exactly the Features section but in middle of the features section.
Fabrik and the text below it can be center aligned with the image in the center.
Thank you! @RishabhJain2018,
@Ram81 @RishabhJain2018, Made the changes! Please have a look. :)
@Ram81 It was already that. I think this problem is because of the screen size. I'll fix it.
Yeah, I apologize for the confusion @sayamkanwar. It should be left aligned only but it should be horizontally centered with the image. Currently, it is top aligned with the center image. Please feel free to ask if there are still doubts.
@Ram81 @RishabhJain2018 Done! :)
@Ram81 I had already fixed that in my last commit where @RishabhJain2018 had pointed out! Please have a look at that. :)
@sayamkanwar I tested it just now and it didn't work for me
Fixed @Ram81
@Ram81 Done! Let me know if any more changes are required! :)
Hey! If I may add a point to the discussion (just a suggestion) .This would be a homepage for Fabrik but we don't have the logo of Fabrik anywhere on the page. We could add it on the landing page maybe?
@Ram81, it was left aligned initially but @RishabhJain2018 had asked to align it in the center of the left margin. So should I change it back to what it was?
@gautamjajoo Thanks for the suggestion! Could you please suggest a good place for the Fabrik’s logo to be added as the header already contains CloudCV’s logo?
@sayamkanwar yes please left align the title. And thanks for the suggestion @gautamjajoo , @sayamkanwar you can replace cloudcv logo with Fabrik's logo
Okay sure @Ram81.
@Ram81
@sayamkanwar also do one thing in features part lets keep three features for now
Closing this PR. I will open a new PR for the homepage.
Hi, I have created the homepage for Fabrik. I have added all the deliverables. The team section currently has sample data, I will replace that with the content when the data is available.
Please review @Ram81 @RishabhJain2018 @utsavgarg Thank you! :)