search

Cloud-CV / Fabrik

:factory: Collaboratively build, visualize, and design neural nets in browser
GNU General Public License v3.0
1.13k stars 235 forks source link

Home Page for Fabrik #486

Closed sayamkanwar closed 5 years ago

sayamkanwar commented 5 years ago

Hi, I have created the homepage for Fabrik. I have added all the deliverables. The team section currently has sample data, I will replace that with the content when the data is available.

Please review @Ram81 @RishabhJain2018 @utsavgarg Thank you! :)

sayamkanwar commented 5 years ago

Added content for the team section.

screenshot 2018-12-04 at 12 05 42 am

@Ram81

sayamkanwar commented 5 years ago

Hi, I have made the changes. Please review @deshraj @virajprabhu Thank you

sayamkanwar commented 5 years ago

@Ram81, made all the changes!

Here's a demo

demo_homepage

sayamkanwar commented 5 years ago

@Ram81, so no demos for the features?

sayamkanwar commented 5 years ago

Is this fine? @utsavgarg @RishabhJain2018

screenshot 2018-12-04 at 11 58 46 pm
sayamkanwar commented 5 years ago

Or would you like something like this? @Ram81 @RishabhJain2018 @utsavgarg

example

(The GIF would be in the place of the image)

PalashTanejaPro commented 5 years ago

If I may add to the discussion, how about GIFs that have a translucent play button on them and play when you hover on them

sayamkanwar commented 5 years ago

@PalashTanejaPro Thanks for the suggestion, but I guess that would be a little out of place because these GIFs were being triggered by clicking on a feature box. So even after once the user has clicked the box, a play button is required? I can add it but it might spoil the user experience.

sayamkanwar commented 5 years ago

@PalashTanejaPro Oh I'm really sorry I misinterpreted your suggestion, that will be a very good feature to be incorporated and will prevent the GIF from being missed by the user. I'll try to include it. Thanks a lot for the suggestion! :)

sayamkanwar commented 5 years ago

Hey, I've changed the design of the demo and added the feature which @PalashTanejaPro had asked for. Please have a look at it here @Ram81 @RishabhJain2018 @utsavgarg:

features

Thank you! :)

sayamkanwar commented 5 years ago

@Ram81 Oh I'm really sorry, I'll fix it.

sayamkanwar commented 5 years ago

Is this fine? @Ram81

screenshot 2018-12-07 at 5 39 40 pm
sayamkanwar commented 5 years ago

@Ram81 Changed the design to what you asked for. I hope it's fine now?

sayamkanwar commented 5 years ago

Is this what you want? @Ram81

screenshot 2018-12-08 at 2 31 32 pm
sayamkanwar commented 5 years ago

Actually, alignment was still a bit messed up, I have corrected it now, @Ram81. Here:

screenshot 2018-12-08 at 5 39 05 pm
sayamkanwar commented 5 years ago

Sure @Ram81

sayamkanwar commented 5 years ago

@Ram81, the homepage would be available at /#/home. :)

sayamkanwar commented 5 years ago

@Ram81, please check now.

RishabhJain2018 commented 5 years ago

The page looks good for a start. Thanks, @sayamkanwar for putting in a lot of effort. Here are some comments:

  1. screenshot 2018-12-08 at 1 23 13 pm Font color of Fabrik is not the same as the color of other fonts in the theme.

  2. Please try Roboto Font.

  3. Whenever I click on features Tab in the header it didn't scroll me to exactly the Features section but in middle of the features section.

  4. Fabrik and the text below it can be center aligned with the image in the center.

sayamkanwar commented 5 years ago

Thank you! @RishabhJain2018,

  1. Yes I know that I thought I should keep it a bit different but I'll change it no issues.
  2. Sure.
  3. I'll look into it.
  4. So image above text? Or text above the image?
sayamkanwar commented 5 years ago

@Ram81 @RishabhJain2018, Made the changes! Please have a look. :)

sayamkanwar commented 5 years ago
screenshot 2018-12-09 at 12 33 43 am
sayamkanwar commented 5 years ago

@Ram81 It was already that. I think this problem is because of the screen size. I'll fix it.

RishabhJain2018 commented 5 years ago

Yeah, I apologize for the confusion @sayamkanwar. It should be left aligned only but it should be horizontally centered with the image. Currently, it is top aligned with the center image. Please feel free to ask if there are still doubts.

sayamkanwar commented 5 years ago

@Ram81 @RishabhJain2018 Done! :)

sayamkanwar commented 5 years ago

@Ram81 I had already fixed that in my last commit where @RishabhJain2018 had pointed out! Please have a look at that. :)

Ram81 commented 5 years ago

@sayamkanwar I tested it just now and it didn't work for me

sayamkanwar commented 5 years ago

Fixed @Ram81

features_scroll

sayamkanwar commented 5 years ago

@Ram81 Done! Let me know if any more changes are required! :)

gautamjajoo commented 5 years ago

Hey! If I may add a point to the discussion (just a suggestion) .This would be a homepage for Fabrik but we don't have the logo of Fabrik anywhere on the page. We could add it on the landing page maybe?

sayamkanwar commented 5 years ago

@Ram81, it was left aligned initially but @RishabhJain2018 had asked to align it in the center of the left margin. So should I change it back to what it was?

sayamkanwar commented 5 years ago

@gautamjajoo Thanks for the suggestion! Could you please suggest a good place for the Fabrik’s logo to be added as the header already contains CloudCV’s logo?

Ram81 commented 5 years ago

@sayamkanwar yes please left align the title. And thanks for the suggestion @gautamjajoo , @sayamkanwar you can replace cloudcv logo with Fabrik's logo

sayamkanwar commented 5 years ago

Okay sure @Ram81.

sayamkanwar commented 5 years ago
  1. Fixed webpack errors.
  2. Replaced cloudcv's logo with fabrik's logo
  3. Left aligned the text
screenshot 2018-12-11 at 5 18 29 pm

@Ram81

Ram81 commented 5 years ago

@sayamkanwar also do one thing in features part lets keep three features for now

  1. Load from Zoo
  2. Export Model
  3. Share Model (Share model and RTC are one and the same)
sayamkanwar commented 5 years ago

Closing this PR. I will open a new PR for the homepage.