search

Cloud-CV / Fabrik

:factory: Collaboratively build, visualize, and design neural nets in browser
GNU General Public License v3.0
1.12k stars 235 forks source link

Refactor tensorflow import backend #499

Closed abhigyan7 closed 5 years ago

abhigyan7 commented 5 years ago

This PR includes a clean, modular code base for tensorflow import. I have split the import logic into two files, much like with the keras and caffe import ones. All the examples inside example/tensorflow work exactly like they used to.

abhigyan7 commented 5 years ago

@Ram81 I did a rebase to combine two of my commits into one, and it looks like I combined the previous commit with https://github.com/Cloud-CV/Fabrik/pull/487/commits/a5fa3f072401cf5f84e2e20b0cbec72a7b4da024 . Should I open a new PR fixing this and then close this one? Will this be an issue when merging?

Ram81 commented 5 years ago

@haabhi while merging we will squash the commits anyway so if all your changes are present in the PR then it shouldn't be an issue.

abhigyan7 commented 5 years ago

@Ram81 Made the changes. I have added docstrings and normal comments where things were not very clear. As for new lines, I have deleted a lot of them and grouped related lines tightly and separated them with single blank lines.

abhigyan7 commented 5 years ago

@Ram81 updated the layer addition tutorial to match these changes.