Open TimVanMourik opened 5 years ago
Because the GitHub login throws an error, a Django debug page is shown and your environment variables are there to see for public. Nothing sensitive (no SECRET_KEY and all), but still.
An error 500 screen should be shown.
Currently the production settings are probably using the regular settings file with DEBUG=True hard-coded in them: https://github.com/Cloud-CV/Fabrik/blob/master/settings/common.py line 14
DEBUG=True
line 14
Either make a separate production settings file or read the DEBUG setting from an environment variable: DEBUG=os.getenv('DEBUG', default_value)
DEBUG=os.getenv('DEBUG', default_value)
@TimVanMourik Can i work on this issue .
To reproduce:
Behaviour
Because the GitHub login throws an error, a Django debug page is shown and your environment variables are there to see for public. Nothing sensitive (no SECRET_KEY and all), but still.
Expected behaviour
An error 500 screen should be shown.
Suggested solution
Currently the production settings are probably using the regular settings file with
DEBUG=True
hard-coded in them: https://github.com/Cloud-CV/Fabrik/blob/master/settings/common.pyline 14
Either make a separate production settings file or read the DEBUG setting from an environment variable:
DEBUG=os.getenv('DEBUG', default_value)