search

Cloud-CV / evalai-cli

:cloud: :rocket: Official EvalAI Command Line Tool
https://cli.eval.ai
BSD 3-Clause "New" or "Revised" License
55 stars 63 forks source link

Updated readme.md as per requirements #196

Open amanex007 opened 4 years ago

amanex007 commented 4 years ago

IMPORTANT NOTES (please read, then delete):

The PR title should start with "Fix #bugnum: " (if applicable), followed by a clear one-line present-tense summary of the changes introduced in the PR. For example: "Fix #bugnum: Introduce the first version of the collection editor.".

Please make sure to mention "#bugnum" somewhere in the description of the PR. This enables Github to link the PR to the corresponding bug.

Please also make sure to follow the style rules.

pushkalkatara commented 4 years ago

Looks good to me!

yashdusing commented 4 years ago

@amanex007 It would be great if you could link the screenshots along with the commands and the context under which the command has to be used. Make a separate document for this.

amanex007 commented 4 years ago

@amanex007 can you make the changes requested by @yashdusing . I am extending your task deadline by 1 day to accomodate these changes slightly_smiling_face

already done

amanex007 commented 4 years ago

@amanex007 can you make the changes requested by @yashdusing . I am extending your task deadline by 1 day to accomodate these changes slightly_smiling_face

I have sent a document prepared by me through the portal.

pushkalkatara commented 4 years ago

@amanex007 Can you please change the title of the PR according to the GCI issue,

I think this PR was for separate issues you worked on, the one i approved was for the previous commit. But, with the new commit in PR, I think the issue is also changed.

pushkalkatara commented 4 years ago

I think you misunderstood the issue. Basically all the functionality implementation is in utils/auth.py and we are importing the functions and using it as a wrapper in the root directory for Click library.

The task was to implement code from L20 to L35 in utils/auth.py. You did right removing the replication, but the part mentioned above is left. Also, it would be better if you use os.makedir() in try-catch block just to be on a safer side.

Please feel free to ask if you have questions, also as @yashdusing said, please share the screenshots in the PR too.