search

Cloud-CV / evalai-cli

:cloud: :rocket: Official EvalAI Command Line Tool
https://cli.eval.ai
BSD 3-Clause "New" or "Revised" License
55 stars 63 forks source link

Fix #181:Introduce pretty print and pager output for challenges #197

Closed RohanSreelesh closed 4 years ago

RohanSreelesh commented 4 years ago

The table that is displayed when the command evalai challenges is used has the respective colors: 1.ID-White 2.Title-Yellow 3.Short Description-Cyan 4.Creator-White 5.Start date- Green 6.End date -Red

It also has pager output enabled so that the command line output is not overwhelming

pushkalkatara commented 4 years ago

Hi @RohanSreelesh The build is failing.

Please add termcolor as a dependency and resolve flake8 formats.

pushkalkatara commented 4 years ago

To resolve flake8 issues:

  1. Locally install flake8 using pip python -m pip install flake8
  2. run the command - flake8 ~/dir/evalai-cli
  3. it would list some errors, resolve accordingly.
RohanSreelesh commented 4 years ago

removed echo_via_pager as it isnt giving consistent outputs

RohanSreelesh commented 4 years ago

Update to tests based on the changes made in the above code

pushkalkatara commented 4 years ago

Good job @RohanSreelesh . Looks good to me. The output - output

yashdusing commented 4 years ago

Also, @RohanSreelesh check for the case for the descriptions are too large or too small. I guess it would be okay to truncate the text after a certain limit. Also check for empty string

pushkalkatara commented 4 years ago

@yashdusing Another student is working on that task and there's an open PR for the same - https://github.com/Cloud-CV/evalai-cli/pull/183

RohanSreelesh commented 4 years ago

@pushkalkatara @yashdusing Is my work regarding this done? if so how may I proceed as my task on gci is still in submitted state. Thanks

yashdusing commented 4 years ago

@RohanSreelesh try synchronising the file by using the 2 files from an earlier build. Then, make changes to it

RohanSreelesh commented 4 years ago

@RohanSreelesh try synchronising the file by using the 2 files from an earlier build. Then, make changes to it

Thanks @yashdusing that worked and now it shows only 1 line as newly added

yashdusing commented 4 years ago

@RohanSreelesh add the missing line as mentioned.

RohanSreelesh commented 4 years ago

@RohanSreelesh add the missing line as mentioned.

which line @yashdusing ? I have added termcolor in both setup.py and requirements

yashdusing commented 4 years ago

@RohanSreelesh line 34 in setup.py. Please check

yashdusing commented 4 years ago

LGTM 👍 @Ram81 @pushkalkatara please verify

pushkalkatara commented 4 years ago

Looks good to me too. Good job @RohanSreelesh .