search

Cloud-CV / evalai-cli

:cloud: :rocket: Official EvalAI Command Line Tool
https://cli.eval.ai
BSD 3-Clause "New" or "Revised" License
55 stars 63 forks source link

Make Output Color Across The CLI Messages Consistent According To Convention #226

Open jayaike opened 4 years ago

jayaike commented 4 years ago

Changes

I used the following colors for the CLI output:

red for errors yellow for questions white for information responses green for success messages

I changed it for all output messages in the EvalAI CLI

jayaike commented 4 years ago

The build seems to be failing due to your tests

jayaike commented 4 years ago

There are some assertion errors so I guess that needs to be resolved

jayaike commented 4 years ago

It seems to be coming from test_request.py

jayaike commented 4 years ago

@RishabhJain2018 , sorry about that. Fixed.

Thanks a lot for pointing it out. I appreciate it

jayaike commented 4 years ago

@RishabhJain

jayaike commented 4 years ago

I fixed all the issues from my end. Sorry about that

pushkalkatara commented 4 years ago

@nsjcorps The build is still failing. You need to update the tests too with the new CLI outputs, also there are flake8 errors. Have a look here for more details.

jayaike commented 4 years ago

@RishabhJain2018 @pushkalkatara After a sleepless night. I have been able to fix it.

Please see the new, updated pull request https://github.com/Cloud-CV/evalai-cli/pull/228