Cloud-CV / evalai-cli

:cloud: :rocket: Official EvalAI Command Line Tool
https://cli.eval.ai
BSD 3-Clause "New" or "Revised" License
55 stars 63 forks source link

[enhancement] Define wrapper functions for click's echo function #234

Open hkmatsumoto opened 4 years ago

hkmatsumoto commented 4 years ago

Current Implementation:

We are calling click's echo function directly each time we call it.

The implementation I propose:

Instead of calling it directly, It sounds good to define wrapper functions like

def print_error(message, bold=True):
    echo(
        style(
            message,
            bold=bold,
            fg="red"
        )
    )

def print_success(message, bold=True):
    echo(
        style(
            message,
            bold=bold,
            fg="green"
        )
    )

and call them to make the codes more descriptive.

ShubhamPandey28 commented 4 years ago

Can I take this and solve along with #243?

hkmatsumoto commented 4 years ago

@ShubhamPandey28 Sure :+1: