Open hkmatsumoto opened 4 years ago
Being different from display_submission_result
, I didn't add error handling codes for requests.exceptions.MissingSchema
because they will not be called even if I add them.
See https://github.com/Cloud-CV/evalai-cli/issues/248 for detail.
@Ram81
The content of stdout file:
The command output:
Looks good to me. @Ram81 let's approve this?
@takitsuse Should we add a failure test case in this PR as well ? If not, then the PR LGTM
@yashdusing I don't think we should add it as long as https://github.com/Cloud-CV/evalai-cli/issues/248 isn't resolved and reachable error handling can't be added.
Can I get an approval on this task then?
Let's approve this @yashdusing We can create a new GCI task with it if required. Approved @takitsuse
@Ram81 @pushkalkatara @yashdusing
It's embarrassing to say this but, it seems I misread the codes due to lack of experience about try-except
clause. The error handling code was reachable in the first place.
I managed to add error handling code that is tested, closing #248.
Sorry for the confusion.
@vkartik97 Added :+1:
By the way, I think I can implement a similar command for stderr
file. Could you make a new GCI task for it if it is okay for you?
Link to the GCI Task:
Changes:
evalai submission SUBMISSION_ID stdout
.CC: @yashdusing @RishabhJain2018 @pushkalkatara @Ram81 @vkartik97