Add command to display the stdout.txt data in terminal

Cloud-CV / evalai-cli

:cloud: :rocket: Official EvalAI Command Line Tool

https://cli.eval.ai

BSD 3-Clause "New" or "Revised" License

55 stars 63 forks source link

Add command to display the stdout.txt data in terminal #247

Open hkmatsumoto opened 4 years ago

hkmatsumoto commented 4 years ago

Link to the GCI Task:

https://codein.withgoogle.com/dashboard/task-instances/5650967840686080/

Changes:

Add a subcommand to show the content of stdout file of the specified submission, invoked by evalai submission SUBMISSION_ID stdout.
Add a helper function of the subcommand.

CC: @yashdusing @RishabhJain2018 @pushkalkatara @Ram81 @vkartik97

hkmatsumoto commented 4 years ago

Being different from display_submission_result, I didn't add error handling codes for requests.exceptions.MissingSchema because they will not be called even if I add them. See https://github.com/Cloud-CV/evalai-cli/issues/248 for detail.

hkmatsumoto commented 4 years ago

@Ram81 The content of stdout file: Screenshot from 2020-01-05 03-17-37

The command output: Screenshot from 2020-01-05 03-17-23

pushkalkatara commented 4 years ago

Looks good to me. @Ram81 let's approve this?

yashdusing commented 4 years ago

@takitsuse Should we add a failure test case in this PR as well ? If not, then the PR LGTM

hkmatsumoto commented 4 years ago

@yashdusing I don't think we should add it as long as https://github.com/Cloud-CV/evalai-cli/issues/248 isn't resolved and reachable error handling can't be added.

hkmatsumoto commented 4 years ago

Can I get an approval on this task then?

pushkalkatara commented 4 years ago

Let's approve this @yashdusing We can create a new GCI task with it if required. Approved @takitsuse

hkmatsumoto commented 4 years ago

@Ram81 @pushkalkatara @yashdusing It's embarrassing to say this but, it seems I misread the codes due to lack of experience about try-except clause. The error handling code was reachable in the first place. I managed to add error handling code that is tested, closing #248. Sorry for the confusion.

hkmatsumoto commented 4 years ago

@vkartik97 Added :+1: By the way, I think I can implement a similar command for stderr file. Could you make a new GCI task for it if it is okay for you?