search

Cloud-CV / evalai-cli

:cloud: :rocket: Official EvalAI Command Line Tool
https://cli.eval.ai
BSD 3-Clause "New" or "Revised" License
55 stars 63 forks source link

Define a generalized function for display_submission_* #253

Open hkmatsumoto opened 4 years ago

hkmatsumoto commented 4 years ago

Changes:

pushkalkatara commented 4 years ago

@takitsuse I think what @vkartik97 meant was using a single submission_result util function to extract all useful content. Adding a new argument in the function i.e. display_submission_result(submission_id, file_name) where file_name can be stdout, stderr etc. Currently, we have all the implementation in utils and using it as a wrapper in the root directory for click library.

hkmatsumoto commented 4 years ago

Okay, is @pushkalkatara's comment what you ment @vkartik97?

krtkvrm commented 4 years ago

Okay, is @pushkalkatara's comment what you ment @vkartik97?

Yes 💯

hkmatsumoto commented 4 years ago

Defined a generalized function as @pushkalkatara's proposal. @vkartik97 Could you take another look?

krtkvrm commented 4 years ago

Can you please fix the travis build?

hkmatsumoto commented 4 years ago

@vkartik97 Fixed :+1:

hkmatsumoto commented 4 years ago

Should I merge this change to https://github.com/Cloud-CV/evalai-cli/pull/252?