Open hkmatsumoto opened 4 years ago
@takitsuse I think what @vkartik97 meant was using a single submission_result util function to extract all useful content. Adding a new argument in the function i.e. display_submission_result(submission_id, file_name)
where file_name can be stdout, stderr etc. Currently, we have all the implementation in utils and using it as a wrapper in the root directory for click library.
Okay, is @pushkalkatara's comment what you ment @vkartik97?
Okay, is @pushkalkatara's comment what you ment @vkartik97?
Yes 💯
Defined a generalized function as @pushkalkatara's proposal. @vkartik97 Could you take another look?
Can you please fix the travis build?
@vkartik97 Fixed :+1:
Should I merge this change to https://github.com/Cloud-CV/evalai-cli/pull/252?
Changes:
display_submission_*
, since those functions will be very similar to each other.