search

Cloud-CV / evalai-cli

:cloud: :rocket: Official EvalAI Command Line Tool
https://cli.eval.ai
BSD 3-Clause "New" or "Revised" License
55 stars 63 forks source link

Fix #243 Added module file for text_styling in utils #254

Open ShubhamPandey28 opened 4 years ago

ShubhamPandey28 commented 4 years ago

Added text_styling.py which solves both issue #234 and #243 at the same time.

nikochiko commented 4 years ago

@ShubhamPandey28 Great work on the issue and kudos on your first PR for CloudCV! 🎉 I loved how you tried to generalize everything in one function. The readability of the code is good as well.

I have left a few queries, so please have a look.

nikochiko commented 4 years ago

Also, please let me know why you chose a single method instead of several helper methods. I was thinking of having several helper methods, so we could add them as we like. So, if we use flags as mentioned and the number of states increases, maintaining the code becomes more difficult.

ShubhamPandey28 commented 4 years ago

the helper functions will be very similar in that case. But you are right, it will be more easy to maintain with those helper functions.