search

Cloud-CV / evalai-cli

:cloud: :rocket: Official EvalAI Command Line Tool
https://cli.eval.ai
BSD 3-Clause "New" or "Revised" License
55 stars 63 forks source link

Add unit tests for evalai push command #261

Closed hkmatsumoto closed 4 years ago

hkmatsumoto commented 4 years ago

The corresponding GCI task

Changes:

hkmatsumoto commented 4 years ago

~~Hi, I added tests for push, but no substantial coverage increase is observed. After some quick investigation, it turned out that coveralls ignores click command functions (and that seems to be the reason why code coverage of this project is high). This is obviously not ideal, could you help me out for the fix?~~

~~c.f: https://coveralls.io/builds/28046756/source?filename=evalai%2Fsubmissions.py In the link above we see a lot of lines which are not painted green nor red, showing that coverage check was not happending on those lines.~~ I created https://github.com/Cloud-CV/evalai-cli/pull/263 to fix this issue.

@vkartik97 @Ram81 @pushkalkatara @yashdusing @RishabhJain2018 Could you take a look at this? Thanks in advance!