Cloud-CV / evalai-cli

:cloud: :rocket: Official EvalAI Command Line Tool
https://cli.eval.ai
BSD 3-Clause "New" or "Revised" License
55 stars 63 forks source link

Code coverage ignores command functions #262

Closed hkmatsumoto closed 4 years ago

hkmatsumoto commented 4 years ago

Observed: Code coverage doesn't check command functions currently, so even if commands are not tested, code coverage will be 100%.

eg: push command in submissions.py is not tested, so code coverage of the file must not be 100 % but is 100% (see here).

nikochiko commented 4 years ago

Can confirm :+1: See this coveralls build: https://coveralls.io/jobs/57952941/source_files/1455465142 I added two functions at the end one of them was a click command: https://coveralls.io/jobs/57952941/source_files/1455465142#L43

I think this is the problem: https://github.com/Cloud-CV/evalai-cli/blob/master/.coveragerc#L9

@takitsuse Nice Catch! 👌

hkmatsumoto commented 4 years ago

@nikochiko I thought the file was clandestine too but was too busy to check that out (thanks, school exam). I'll give it a try :+1:

nikochiko commented 4 years ago

np! 😄