search

Cloud-CV / evalai-cli

:cloud: :rocket: Official EvalAI Command Line Tool
https://cli.eval.ai
BSD 3-Clause "New" or "Revised" License
55 stars 63 forks source link

Refactor login command #268

Open hkmatsumoto opened 4 years ago

hkmatsumoto commented 4 years ago

Changes:

I removed the code duplication between: https://github.com/Cloud-CV/evalai-cli/blob/master/evalai/login.py#L21-L25 https://github.com/Cloud-CV/evalai-cli/blob/master/evalai/login.py#L29-L33

@vkartik97 @yashdusing @RishabhJain2018 @pushkalkatara @Ram81 Could you take a look? Thanks in advance!

pushkalkatara commented 4 years ago

@takitsuse Also can you move the refactored code to and use login.py just as a wrapper. This would enable us to keep all the functionality in one place and click wrappers in one place.

hkmatsumoto commented 4 years ago

@pushkalkatara I got it. I'll make changes after school classes end.

hkmatsumoto commented 4 years ago

@vkartik97 I'm struggling to do so. The added test passes but it somehow affects other tests.

hkmatsumoto commented 4 years ago

@vkartik97 By the way, could you take a look at https://github.com/Cloud-CV/evalai-cli/pull/263? I think the PR very important to know the actual code coverage.

hkmatsumoto commented 4 years ago

@vkartik97 After a bitter fight, I successfully fixed the build. Please take another look :+1: