Open hkmatsumoto opened 4 years ago
@pushkalkatara I got it. I'll make changes after school classes end.
@vkartik97 I'm struggling to do so. The added test passes but it somehow affects other tests.
@vkartik97 By the way, could you take a look at https://github.com/Cloud-CV/evalai-cli/pull/263? I think the PR very important to know the actual code coverage.
@vkartik97 After a bitter fight, I successfully fixed the build. Please take another look :+1:
Changes:
I removed the code duplication between: https://github.com/Cloud-CV/evalai-cli/blob/master/evalai/login.py#L21-L25 https://github.com/Cloud-CV/evalai-cli/blob/master/evalai/login.py#L29-L33
@vkartik97 @yashdusing @RishabhJain2018 @pushkalkatara @Ram81 Could you take a look? Thanks in advance!